Progress throbber position is incorrect

Patch #106 with some modifications.

I have created this patch for 10.1.x-dev and its working fine. Please verify.

Thank you @dsandhya! It looks like the approach that you are trying is pretty close to what we'd want. However, it requires using position: absolute which may lead into some difficulties with the placement of the throbber. Have you seen the new approach that we are trying on the MR where we are trying to move the throbber outside the dropbutton containers? I'm wondering if you have thoughts on that.

In table:

In modal:

Added a change record for the new data attribute "data-drupal-ajax-container"

Updating credits

I want to Work on this issue can i get assigned??

Updating credits

bnjmnm → closed merge request !3871

This is committed to 10.1.x. Running tests on 10.0.x to make sure everything cooperates with the build dependencies before backporting.

It looks like this issue had multiple instances of people re-uploading patches to initiate tests. This is not necessary as every patch has a link below it that says "Add test / retest". Click into that and you can start a new round of tests without having to add another comment.

This issue also had multiple instances of comments that pasted in information that from the test runner results. There's no need to transfer that information to a comment, the information is already available by clicking into the peach colored results link that will say something like "PHP 8.1 & MySQL 5.7 29,370 pass, 2 fail"

There were a bunch of "Custom commands failed" patches as well. With gitlab MRs this is less noisy, but the comments can make an issue hard to follow. This is bound to happen on occasionYou can check for Custom Commands Failed locally without having rely on the Drupal testbot. Notice at the end of the fail reports it says

Drupal code quality checks failed.
To reproduce this output locally:
* Apply the change as a patch
* Run this command locally: sh ./core/scripts/dev/commit-code-check.sh
OR:
* From the merge request branch
* Run this command locally: sh ./core/scripts/dev/commit-code-check.sh --branch 10.1.x

I also noticed that comment #9 from October 2019 suggested the approach that ultimately was used

I'm wondering if we would be able to change the ajax logic so that the throbber would be rendered outside the dropbutton? If not, we should try to style it so that there's no visual indication that the throbber is rendered inside dropbutton.

but was not even attempted until 100+ comments later in April 2023. Even if someone saw this recommendation, I can understand why it might have not been tried. I've noticed that solving via CSS only can seem safer and easier because it's "only" changing presentation. However, it is often the approach most likely to cause side effects and not cover certain edge cases. A JS/Markup fix can often be the less disruptive approach, even if the changes seem like they're more invasive.

This bugfix is worth backporting. It currently does not apply to 10.0.x, however

I have attached patch for 10.0.x. please review

Seems reroll for 10.0.x had some issues.

Tests seems passing now.

Reroll seems to be passing.

Backported to 10.0.x. While this this is technically an API change, the risks are low as it would require the deliberate addition of a pre-existing data-drupal-ajax-container attribute somewhere on the site accompanied by several very specific customizations - and were such a scenario to occur the trivial impact would be outweighed by the benefits of this fix.

bnjmnm → closed merge request !3872

Automatically closed - issue fixed for 2 weeks with no activity.