Last access by a user should not change after masquerade as that user (D8)

Patch looks good after running db update on latest 10.0.9!

Adjusted patch for rc3

The last submitted patch, 45: 3042321_45.patch, failed testing. View results →

Aren't you mixing up $this->authUser and $this->auth_user in Functional/MasqueradeTest.php?
$this->auth_user is undefined in the first line of function testMasquerade().

Might be. I didn't care about the tests and just adjusted the existing patches here to by able to be applied against the latest versions.

Thanks for adjusting the patch for masquerade 8.x-2.0-rc3. Let us see what the attached patch does in the tests.

Well. 2 failing tests fixed. A bit better.

I took a quick look at the failing tests.

RTBC +1

@Jan-E you can set the issue status to RTBC.

The last patch erroneously modified the info.yml

Thank you! Pushed to -dev version as rc4 bugfix just rolled out

Missed one coding standards message but fine

tests/src/Kernel/ServiceDecoratorsTest.php ✗ 1 more
line 11 The class short comment should describe what the class does and not simply repeat the class name

For the record: #56 🐛 Last access by a user should not change after masquerade as that user (D8) Fixed applies without problems to masquerade 8.x-2.0-rc4.

Automatically closed - issue fixed for 2 weeks with no activity.

Should a new issue be opened for adding a configuration form for updating this setting? It's not a big need for me, as I can set the config value. But others might not be able to do that.

I think it needs some readme update as it will be confusing if masquerade will update last accessed