- Issue was unassigned.
- Status changed to Needs review
9 months ago 1:19pm 19 August 2024 - 🇺🇦Ukraine nginex
Did not check previous patches, just used core/once to handle the issue with multiple issues
- 🇯🇴Jordan Ahmad Khader
I tested the patch mentioned in #12, and it was successful for me. However, I believe we should format the hiddenInput to INTERNATIONAL rather than E164, as the placeholder suggests the presence of spaces.
It would be nice if in the future we added a format option to display the field
- 🇺🇸United States jcandan
I think I see what happened. It seems Ahmad's #17 patch mistakenly missed somethings, #18 is a re-roll of #12 with his desired change to INTERNATIONAL format rather than E164.
- 🇺🇸United States jcandan
This is a big undertaking. While I do believe it is ideal to tackle issues distinctly, the frequency of updates to this module has made it such that a big change affecting multiple bugs is inevitable. I will review this further. I plan to add tests as described in #10. Thanks, everyone.
- 🇺🇸United States jcandan
Option 1: intlTelInputWithUtils
If you're not concerned about filesize (e.g. you're lazy loading this script), the easiest thing to do is to just use the full bundle (/build/js/intlTelInputWithUtils.js), which comes with the utils script included. This script can be used exactly like the main intlTelInput.js - so it can either be loaded directly onto the page (which defines window.intlTelInput like usual), or it can be imported like so: import intlTelInput from "intl-tel-input/intlTelInputWithUtils".
-- https://github.com/jackocnr/intl-tel-input?tab=readme-ov-file#loading-th...Given this is loaded when the widget is used, let's adopt the above implementation in lieu of the changes made from #11.
- 🇺🇸United States jcandan
Never mind. That
intlTelInputWithUtils.js
doesn't even come with the package. Must be outdated docs. - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue tag for Commerce is Commerce 2.x. Since somebody used another tag, that has been renamed Commerce 2.x (duplicate) to make clear it should not be used.
- 🇺🇸United States jcandan
Got a test added and refactored the work from the above patches and MR !8. Good job and thanks , everyone.
Please, someone review MR !9.