The above workaround works only for Olivero, if you change the theme to Claro, the message is duplicated again.
Maybe a feature or bug in Olivero?
Found a way to reproduce the issue:
1. Import yml file in the attachment
2. Test form, select option b
3. Select option 'Other...'
4. Submit form
5. Error 'Other req if B field is required. ' is visible two times
A workaround for this issue is to change the 'wrapper type' to 'fieldset', the option can be found under the advanced tab of the form element.
Or remove the `#wrapper_type` from the config file.
The conditions are maybe not needed, but didn't test that.
tess bakker → created an issue.
tess bakker → created an issue.
Removal of issue 3324621, fixed in 4.0.20
Thanks all!
Sorry forgot to add the validation report:
$ ddev phpcs -v
Registering sniffs in the drupal-project standard... DONE (126 sniffs registered)
Creating file list... DONE (10 files in queue)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src
Processing EnvironmentIndicatorForm.php [PHP => 602 tokens in 81 lines]... DONE in 19ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorPermissions.php [PHP => 273 tokens in 47 lines]... DONE in 3ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Entity
Processing EnvironmentIndicator.php [PHP => 1028 tokens in 206 lines]... DONE in 11ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Form
Processing EnvironmentIndicatorSettingsForm.php [PHP => 491 tokens in 65 lines]... DONE in 6ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src
Processing ToolbarHandler.php [PHP => 2225 tokens in 333 lines]... DONE in 28ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorListBuilder.php [PHP => 489 tokens in 67 lines]... DONE in 6ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorAccessControlHandler.php [PHP => 198 tokens in 31 lines]... DONE in 3ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Element
Processing EnvironmentIndicator.php [PHP => 172 tokens in 35 lines]... DONE in 2ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator
Processing environment_indicator.module [PHP => 2047 tokens in 253 lines]... DONE in 21ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/modules/environment_indicator_ui/src/Form
Processing EnvironmentIndicatorUISettingsForm.php [PHP => 650 tokens in 85 lines]... DONE in 7ms (0 errors, 0 warnings)
PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
------------------------------------------------------------------------------------------------------------------------------------------------------------
/var/www/html/web/modules/custom/environment_indicator/environment_indicator.module 0 0
/var/www/html/web/modules/custom/environment_indicator/modules/environment_indicator_ui/src/Form/EnvironmentIndicatorUISettingsForm.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorAccessControlHandler.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorForm.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorListBuilder.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorPermissions.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/ToolbarHandler.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/Element/EnvironmentIndicator.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/Entity/EnvironmentIndicator.php 0 0
/var/www/html/web/modules/custom/environment_indicator/src/Form/EnvironmentIndicatorSettingsForm.php 0 0
------------------------------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS AND 0 WARNINGS WERE FOUND IN 10 FILES
------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 175ms; Memory: 6MB
@riddhi.addweb This issue is about PHP Code style issues. Yes it can check CSS and JS, but there should be a new issue to enable StyleLint.
Looks good!
A documentation page exist for 4.x:
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
Re-roll needed for 4.x
3.x is no longer supported, is this still an issue in 4.x ?
If 4.x is still affected, please set status to 'Needs work' and add screenshot with the issue.
Version 3.x is no longer supported and the issue is fixed in 4.x
It's better to use _title_callback in the route definition. See node.routing.yml for an example.
Nice catch!
I would suggest to remove #3065135: Add support for multilingual domain sites → from the list, because it needs more work and isn't a blocking issue.
Works! Delete still works and fixing the class is not needed as it will function not any different from the parent.
That is a good start!
A new issue could be created to explain more "secret"/advanced features of the module.
Works!
MR 56 needs work, the new url contains a double forward slash '/', one for the domain, one for the beginning of the path.
Change works as expected:
Update hook isn't needed, existing data remains intact.
Duplicate issue, related ticket is already reviewed. If something is missing, please update the related ticket.
Created a new MR with the recent changes, based on MR1
The issue itself is fixed in #3, patch applied successful.
MR !1 addresses the existence of drupal/once, but Drupal 9 is already outdated, so I would suggest, use patch #3.
Nice work!
Works perfect.
Tess Bakker → created an issue.
I think these were the last changes.
Created a MR, because it is easier to review.
Tess Bakker → created an issue.
Nice work! Here is some feedback for MR !5
- The configure option isn't really a configure page as mentioned in #1786994-4: Add a "configure" link directly on "modules" list → , maybe some day if ✨ Add configuration so sites can customize which calls, files, and functions to ignore Needs work is committed?
- potx.module:28 , two lines earlier, an early return is placed. The Else-statement isn't needed.
- The description in potx.links.menu.yml is almost the same as the title, maybe something like: 'Get the translation from modules or themes.'?
- Readme.md: "The potx Drush command provided by the module. Examples:" should be a heading not a list item.
- I think it would be better to display a summary of the help or a hint to the Drush command feature on the actual potx page and an extended help on the help page. See `path_help()` for an example.
Added the check as suggested in #3159088-3: Extract english translations →
Added the same D8 tests for the D7 branch.
Tess Bakker → changed the visibility of the branch 3412541-fieldtypeadvanced-descriptive-texts to active.
Tess Bakker → changed the visibility of the branch 3412541-fieldtypeadvanced-descriptive-texts to hidden.
Tess Bakker → created an issue.
MR for 8.x created based on the patch for 7.x.
Patch for 7.x has some spelling issues.
Needs a MR or patch for 8.x-1.x
Merge conflict, GitLab CI file was added within commits:
Added some tests for D8+ skipped D7.
Tess Bakker → made their first commit to this issue’s fork.
Plural formula is correct:
* https://translate.fedoraproject.org/languages/ca/#information
pt-pt language code is correct:
* https://localize.drupal.org/translate/languages/pt-pt
plural formula is correct:
* https://translate.fedoraproject.org/languages/pt_PT/#information
patch applied with success
No longer an issue in the latest dev version.
gl language code is correct:
Plural format is correct:
- http://docs.translatehouse.org/projects/localization-guide/en/latest/l10...
- https://translate.fedoraproject.org/languages/gl/#information
Patch failed of incorrect whitespace use. A new patch is attached.
Didn't find any issues with exporting translations.
The happy path works as expected, but if the directory creation fails, follow-up errors will occur.
Throwing an exception could help users more with the actual issue.
if (!file_exists($destination) && !mkdir($destination, 0755, TRUE) && !is_dir($destination)) {
throw new \RuntimeException(sprintf('Directory "%s" was not created', $destination));
}
Test call: drush potx --destination=/tm/p --folder=/var/www/html/web/core/modules/action
Tess Bakker → created an issue.
Re-roll
Added a ticket about a request for examples, maybe add some of those requests into the template?
Tess Bakker → created an issue.
Tess Bakker → created an issue.
Project no longer maintained. No plans to support Drupal 10.
Alternative suggested has stable release for Drupal 8+
Module no longer maintained. Patch can be used if needed.
Thanks for the fixes.
Tess Bakker → made their first commit to this issue’s fork.
Could use a test to validate the case in comment #7 for double escaping.
The Action type element, introduced in #128 conflicts with the Javascript implementation in Drupal.behaviors.dialog.prepareDialogButtons.
Buttons of multiple field values are now displayed in the button area of a dialog.
Screenshot: