'- Cloned' string should be translatable

As the ticket responsible for postponing this has been merged and fixed (and released), I've re-rolled the latest patch against 2.x.

And putting it back to needs review

@SpadXIII thanks! Why are you adding Markup::create()? Doesn't that introduce security risks?
It wasn't there before, so I don't know yet, why it should be needed?

BTW, Tests are failing, but that might be unrelated?

I seem to have forgotten to add a use-statement. Fixed in new patch.

Agree with @Anybody Markup::create() isn't required.

Please review.

Could use a test to validate the case in comment #7 for double escaping.

Please review the MR, I have tried to write some addition test cases as per @Tess Bakker requirement.

Thanks

I am a bit confused about the status of this issue.

Imho patch from #14 was the best solution so far, maintainer just requesting to not use Markup::create.

Merge Request #40 seems a bit of a mess now, i. e. what is "commerce_product_ui_product_form" doing in there?

I am providing patch based on #14 without Markup::create to maybe get this going again.

Regarding tests: Not sure what should be tested and how and if additional test is really necessary.

@stefan.korn agreed! :) Test: See #21 and I think that makes sense. Just ensure there's no double escaping for special characters in the title.

@Anybody: Okay, I am not sure about the double escaping. So we would need the Markup::create still to resolve this?

And changing to 2.x branch as this is current.

So testing this, it seems without Markup::create special characters in the title will indeed be double escaped. This would mean #15 is still the way to go.

now this patch based on #15 but applying to 2.x branch.

@stefan.korn thanks, seems you're right. Guess that happens because of https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...

Perhaps we can find a pattern in core for this case? Otherwise we need to find out, if we introduce security risks here and if yes, which. Perhaps they can be mitigated by using a different method? (If needed). Sorry I'm unsure myself.