Coding standards and best practices

Hi, Uploading a patch for the fix.

I am trying to apply the "coding-standards-and-3338199-2.patch" but there is an error in the patch.
Please check the Screenshot for the same.

I have applied the MR !50 cleanly and it resolves all the issues.
Please check the screenshot for the same.

This Merge Request appears to resolve all of the PHPCS errors. https://git.drupalcode.org/issue/environment_indicator-3338199/-/jobs/30...

I've updated the fork to include upstream changes, most importantly, the gitlab ci config file.

Additionally, I've configured gitlab CI to block merging if PHPCS tests fail in the future as to not allow merging any code that doesn't comply with Drupal coding standards in the future.

See
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Looks good!

FYI, this merge request updates CSS, which is not covered by PHPCS, so I'll remove those changes here so that we can fix the CSS in a separate MR.

I tried to apply the MR and it applied cleanly, but seems like still the PHPcs issues are not resolved. Attaching SS for the same.

@riddhi.addweb This issue is about PHP Code style issues. Yes it can check CSS and JS, but there should be a new issue to enable StyleLint.

Sorry forgot to add the validation report:

$ ddev phpcs -v
Registering sniffs in the drupal-project standard... DONE (126 sniffs registered)
Creating file list... DONE (10 files in queue)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src
Processing EnvironmentIndicatorForm.php [PHP => 602 tokens in 81 lines]... DONE in 19ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorPermissions.php [PHP => 273 tokens in 47 lines]... DONE in 3ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Entity
Processing EnvironmentIndicator.php [PHP => 1028 tokens in 206 lines]... DONE in 11ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Form
Processing EnvironmentIndicatorSettingsForm.php [PHP => 491 tokens in 65 lines]... DONE in 6ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src
Processing ToolbarHandler.php [PHP => 2225 tokens in 333 lines]... DONE in 28ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorListBuilder.php [PHP => 489 tokens in 67 lines]... DONE in 6ms (0 errors, 0 warnings)
Processing EnvironmentIndicatorAccessControlHandler.php [PHP => 198 tokens in 31 lines]... DONE in 3ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/src/Element
Processing EnvironmentIndicator.php [PHP => 172 tokens in 35 lines]... DONE in 2ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator
Processing environment_indicator.module [PHP => 2047 tokens in 253 lines]... DONE in 21ms (0 errors, 0 warnings)
Changing into directory /var/www/html/web/modules/custom/environment_indicator/modules/environment_indicator_ui/src/Form
Processing EnvironmentIndicatorUISettingsForm.php [PHP => 650 tokens in 85 lines]... DONE in 7ms (0 errors, 0 warnings)

PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                                                        ERRORS  WARNINGS
------------------------------------------------------------------------------------------------------------------------------------------------------------
/var/www/html/web/modules/custom/environment_indicator/environment_indicator.module                                                         0       0
/var/www/html/web/modules/custom/environment_indicator/modules/environment_indicator_ui/src/Form/EnvironmentIndicatorUISettingsForm.php     0       0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorAccessControlHandler.php                                     0       0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorForm.php                                                     0       0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorListBuilder.php                                              0       0
/var/www/html/web/modules/custom/environment_indicator/src/EnvironmentIndicatorPermissions.php                                              0       0
/var/www/html/web/modules/custom/environment_indicator/src/ToolbarHandler.php                                                               0       0
/var/www/html/web/modules/custom/environment_indicator/src/Element/EnvironmentIndicator.php                                                 0       0
/var/www/html/web/modules/custom/environment_indicator/src/Entity/EnvironmentIndicator.php                                                  0       0
/var/www/html/web/modules/custom/environment_indicator/src/Form/EnvironmentIndicatorSettingsForm.php                                        0       0
------------------------------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS AND 0 WARNINGS WERE FOUND IN 10 FILES
------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 175ms; Memory: 6MB

@riddhi.addweb thanks for testing locally.

This merge request is simply aiming to make the checkmark next to phpcs green with out any additional changes (which it does).

https://git.drupalcode.org/issue/environment_indicator-3338199/-/pipelin...