field_type_advanced descriptive texts still not translateable

This is looking for @Translation to be preceded by = https://git.drupalcode.org/project/potx/-/blob/46e7fc79155563144f4f2f361...

Assuming this is valid syntax for Drupal core, either the = should be removed or additional possibilities for preceding characters.

We can probably remove the requirement for the =, I don't think we expected list items be translated like that when we wrote that code. Patch would be relatively easy I think. A fail text could prove such an annotation as in the issue summary does not get parsed currently while a pass patch would show it does when the = requirement in the matching is removed.

Should be coded against both 7.3 and 8.1.

Let's see what the tests do :)

All green 🙂 manually tested the regex and to me it seems this is doing what we are expecting it to do.

Thank you all for fixing that issue, again. I'm looking forward to the commit of this so we can update the user guide for Drupal 10.2.0

I agree the fix looks good. Would be great to add test coverage for the list item case (test items to the sample PHP file we have and verify in the test that they are found). Thanks!

Is something preventing preventing us from applying this, still?

Tess Bakker → made their first commit to this issue’s fork.

Added some tests for D8+ skipped D7.

Are we able to test and fix this meanwhile? Currently it is the last untranslated pice in Core.

Tess Bakker → changed the visibility of the branch 3412541-fieldtypeadvanced-descriptive-texts to hidden.

Tess Bakker → changed the visibility of the branch 3412541-fieldtypeadvanced-descriptive-texts to active.

Added the same D8 tests for the D7 branch.

Looks good on a patch review, added test coverage looks great.

Thanks all! I am not sure how @drumm updates the live site's potx, but once that is done, this will be online.

Automatically closed - issue fixed for 2 weeks with no activity.

I am not sure if this is really fixed. Shouldn't a fix lead us to some new translatable ui strings in core at least? They are still missing, so we should re-open this issue.

This hadn’t been deployed to localize.drupal.org yet, but is now.

We’ll need to know which releases need a re-parse to fully have this done.

This looks like 10.2.* were affected, those have been set to reparse on localize.drupal.org