Contrib.social

Drupal 11 compatibility fixes for potx, including new test coverage

Open on Drupal.org →
Created on 24 March 2024, 9 months ago
Updated 23 July 2024, 5 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    18 pass
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !18Automated Project Update Bot fixes → (Merged) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    18 pass
  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇳🇱Netherlands tess bakker

    Didn't find any issues with exporting translations.

  • First commit to issue fork.
  • Comment 6 months ago →
    🇩🇪Germany jurgenhaas Gottmadingen

    I've added Drupal 11 to the supported core versions in the info file as well.

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇭🇺Hungary Gábor Hojtsy Hungary

    - Gitlab CI config should be updated to run the tests on the next major. That would prove that at least the tests still pass on Drupal 11.

    - There is this change in the diff, does this still work on Drupal 8? What's the minimal version this still works on? We could potentially keep Drupal 8 support by making the code conditional?

    diff --git a/potx.inc b/potx.inc
index 391275fbd664af69cd45bfdd70355221d183011a..56d1397bf3bbbd521491328e06a705db6a3274e1 100644
--- a/potx.inc
+++ b/potx.inc
@@ -573,7 +573,7 @@ function _potx_translation_export($translation_export_langcode, $string, $plural
     include_once 'includes/locale.inc';
   }
   else {
-    module_load_include('inc', 'potx', 'potx.locale');
+    \Drupal::moduleHandler()->loadInclude('potx', 'inc', 'potx.locale');
   }
 
   // Strip out slash escapes.
  • Comment 6 months ago →
    🇭🇺Hungary Gábor Hojtsy Hungary

    Tests pass on Drupal 10 and 11, but not on 9. That is not really on this issue to solve. That said, I can visibly see that the Drush command will not work with Drush 13, not even 12, because its not in the right place. So we need to fix that and also potentially add tests. https://git.drupalcode.org/project/upgrade_status/-/blob/4.x/tests/src/F... are Drush tests we use elsewhere and could be useful here.

  • Comment 6 months ago →
    🇭🇺Hungary Gábor Hojtsy Hungary
  • Pipeline finished with Skipped
    6 months ago
    #219609
  • Comment 6 months ago →
    System Message
  • Status changed to Fixed 6 months ago
  • Comment 6 months ago →
    🇭🇺Hungary Gábor Hojtsy Hungary
  • Comment 5 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024