- Issue created by @emptyvoid
- ๐ฎ๐ณIndia Rajan Kumar@2026
rajan kumar@2026 โ made their first commit to this issueโs fork.
- Status changed to Needs review
3 months ago 7:04am 27 August 2024 - ๐ฎ๐ณIndia Rajan Kumar@2026
Hi @emptyvoid
I have applied the above patch successfully and created a (MR). I tested it in the local environment and also checked the Drupal Upgrade Status module for compatibility with Drupal 11. A screenshot is attached for reference. Thank you.
- ๐ณ๐ฑNetherlands Marty2081
The patch is incorrect. The following code will fail:
Error::logException('a11y_form_helpers', $exception);
The logException() method requires the first argument to be a class that implements the LoggerInterface and not a string. See https://www.drupal.org/node/2932520 โ
The code should be:
$logger = \Drupal::logger('a11y_form_helpers'); Error::logException($logger, $exception);
The second question is why catching the PluginException is replaced by catching Exception?
- ๐ณ๐ฑNetherlands Marty2081
Scratch my previous patch. I found out the first try/catch was useless anyway, so this new patch removes that and also makes sure an empty array is returned when there is no purpose.
Here is an updated patch.