Contrib.social

Support Symfony Mailer

Open on Drupal.org →
Created on 29 December 2023, over 1 year ago
Updated 30 December 2023, over 1 year ago

Problem/Motivation

Support for Symfony Mailer →

Steps to reproduce

  1. Setup Symfony Mailer
  2. Enable a TFA method
  3. Possible mail failure from Symfony Mailer
  4. Disable TFA
  5. Possible mail failure from Symfony Mailer

Both mails are also not configurable with all the extra config options Symfony Mailer has.

Proposed resolution

Create Email Builder for TFA

Remaining tasks

  • Test MR
  • Merge MR

User interface changes

Mail fields (subject and body) will be replaced by Symfony Mailer.

API changes

tfa_mail() hook will be skipped.

Data model changes

tfa.settings.yml will be ignored, a new config file will be generated.

✨ Feature request
Status

Needs work

Version

2.0

Component

Code

Created by

🇳🇱Netherlands tess bakker

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tess bakker
  • Merge request !68Support Symfony Mailer → (Open) created by tess bakker
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇳🇱Netherlands tess bakker
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States cmlara

    Trying to understand "Possible mail failure from Symfony Mailer" with regards to triaging this. What failure occurs and how frequent/what causes it?

    The PHPStan warnings need to be cleared up (either by including a dev dependency or stubbing) and the new code will need tests (preferably Unit) to validate it functions as designed.

    tfa.settings.yml will be ignored, a new config file will be generated.

    Can you provide context, for what is being ignored and why?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024