- Issue created by @ldonelan
- ๐ช๐ธSpain ckrina Barcelona
Thank you @ldonelan! I've updated the links to use the pattern for issue numbers so the state gets pulled automatically.
- ๐ช๐ธSpain ckrina Barcelona
More issues added to define the plan better.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Bumped ๐ Revert to default in navigation layout settings from the UI Active down to "Could Have" as a lower priority non-MVP item, after discussion on the weekly Admin UI call. @ckrina to follow up with @laurii about this feature as well to get some clarity around it. More details in the ticket.
- ๐ช๐ธSpain ckrina Barcelona
Adding ๐ Decide strategy to customize or provide 1st level menu items' icons Active as a Stable Must Have.
- ๐บ๐ธUnited States KeyboardCowboy Denver, CO, USA
@ckrina, I reorganized tickets based on our discussion. Let me know if this looks OK or if you'd like a different format.
- ๐ช๐ธSpain ckrina Barcelona
Updating with completed, specially to get a sense of missing tasks for the beta release.
- ๐ฌ๐งUnited Kingdom catch
From looking at https://git.drupalcode.org/project/navigation/-/commit/17970de1ed6b4129d... it looks like there is not yet a caching strategy for the menu links in the navigation module.
The existing toolbar has a very developed caching system already, this was implemented in #1814932: Caching strategy for D8 toolbar โ , #1137920-303: Fix toolbar on small screen sizes and redesign toolbar for desktop โ and #1805054: Cache localized, access filtered, URL resolved, and rendered menu trees โ and has not significantly changed since.
It was necessary to add this because rendering a full tree of admin menu links is very expensive both in terms of server-side processing (hundreds of milliseconds every request) and page weight (potentially hundreds of extra kb every request).
I think we need an issue to port this logic across from the existing toolbar.
- ๐ช๐ธSpain ckrina Barcelona
Thanks @catch! I've created the issue to keep track of it ๐ Implement a caching strategy for the menu links Active and added it as stable blocker.
- ๐ช๐ธSpain ckrina Barcelona
Moving ๐ [META] Implement the final design system Fixed to done, and removing ๐ฑ [PLAN] Accessibility review Active from beta blocker as the reviews have started. Any issue found will be added as Stable blocker if necessary.
Also adding ๐ Remove postcss-px-to-rem from Navigation Active as it'd be a really nice cleanup to have. - ๐ช๐ธSpain ckrina Barcelona
Removing the Beta section since everything needed for beta has been done and we're about to launch beta 3.
I moved ๐ฑ [PLAN] Accessibility review Active to the Should have, and if any Accessibility bug found becomes an Stable blocker it'll be included into the "Must have" section.
- ๐ช๐ธSpain ckrina Barcelona
Updated with new stable blockers and removed fixed issues.
- ๐ช๐ธSpain ckrina Barcelona
Adding ๐ Investigate using the core "User account menu" in favor of custom Navigation Block for same Active as stable blocker.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Added โจ For RTL languages, Navigation menu should show on the right Active . IMHO is a "must" for stable, but we would want to check with RTL languages' native speakers.
- ๐ช๐ธSpain ckrina Barcelona
Adding a new stable blocker: ๐ Navigation layout Drag is not working in some browers Active .
- ๐ซ๐ฎFinland lauriii Finland
Adding ๐ Mark Navigation as beta experimental Active as a reference for beta stability sign-offs.
- ๐ฌ๐งUnited Kingdom AaronMcHale Edinburgh, Scotland
๐ Decide strategy to customize or provide 1st level menu items' icons Active appears twice under the must have list, not sure if that was an oversight or if one of those was meant to be a link to a different issue?
- ๐ช๐ธSpain ckrina Barcelona
Moving ๐ The toolbar should be usable without JS Needs work to the Should have section.
- ๐ช๐ธSpain plopesc Valladolid
Added ๐ Special Menu items are rendered as empty links in navigation RTBC
- ๐ช๐ธSpain ckrina Barcelona
Adding ๐ฑ [META] Migrate Navigation to SDC Active and removing completed tasks.
- ๐ฉ๐ชGermany anruether Bonn
May I ask why you removed the links to the issues, @ckrina?
- <li> ๐ฑ [PLAN] Icons for the sidebar Active (Ability to choose icons on the UI)</li> + <li>Ability to choose icons on the UI</li> - <li>Environment Indicator</li> + <li> โจ Support for core navigation experimental module Needs work </li>
- ๐ช๐ธSpain ckrina Barcelona
Updating with the issues for core modules that need integrations.
- ๐ช๐ธSpain ckrina Barcelona
Moving another one into the should have. This is not a critical action for the navigation itself, only if you want to customize it. It should get done, but not block this becoming stable.
- ๐ฉ๐ชGermany anruether Bonn
There are two more issues that have originally been reported on in the feedback issue, that have not been prioritized yet:
- ๐ฌ๐งUnited Kingdom catch
โจ Provide Config Action to add new blocks to navigation from recipes Active looks to me like it wouldn't need to be stable blocking too - it's not user-facing and it won't require any API deprecations or storage changes, just a small API addition. I realise it might be Drupal CMS blocking but that's different thing in terms of module stability.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Adding a couple of issues marked stable blocker that were not in the issue summary here under "Must Have".
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Added ๐ Second level menu items can't be reached if they have children Active under "Could have"
- ๐ช๐ธSpain ckrina Barcelona
Removing fixed issues! :D
โจ Provide Config Action to add new blocks to navigation from recipes Active
- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
Updated top bar explanation based on discussion with @ckrina
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Added ๐ Layout Builder Create Inline blocks logic should be optional Active as Must have.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Removed ๐ Layout Builder Create Inline blocks logic should be optional Active per conversation in Slack from Must have, dropped to Should have.
- ๐ฌ๐งUnited Kingdom catch
With ๐ Implement a caching strategy for the menu links Active RTBC, I am starting to think we could skip doing ๐ Implement a caching strategy for the menu links Active , especially if we can figure out ๐ Render the navigation toolbar in a placeholder Active . We probably want to check exactly how much HTML we're sending to the browser, but otherwise those two issues should speed things up considerably.
- ๐ฌ๐งUnited Kingdom catch
Discussed the above a bit more with @plopsec and swapped out ๐ Implement a caching strategy for the menu links Active for ๐ Render the navigation toolbar in a placeholder Active in the issue summary.
- ๐ช๐ธSpain ckrina Barcelona
Adding ๐ Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar RTBC as a should have.
- ๐ช๐ธSpain ckrina Barcelona
Adding ๐ Evaluate if the Top Bar entity title needs to show extra Active as a should to have.
- ๐ช๐ธSpain ckrina Barcelona
Cleaning up Stable blockers to simplify the review of missing work for stable release.
- ๐ซ๐ฎFinland lauriii Finland
Adding ๐ Styling of front theme affects styling of navigation buttons Active to the top of the should have list since it has a major DX impact.
- ๐ช๐ธSpain ckrina Barcelona
Add un-tracked issues marked as Navigation blockers. Let's discuss if they are really blocking the release.
- ๐ฌ๐งUnited Kingdom catch
Removing ๐ Render the navigation toolbar in a placeholder Active because that's all done except for the big pipe-agnostic js follow-up which is in progress!
Really happy with how that all turned out - we can drop the old complex toolbar menu tree caching client side code, solving all the problems that tried to solve without introducing new ones like flicker, and also it's opened up significant new performance improvements for core at the same time.
- ๐ซ๐ฎFinland lauriii Finland
Adding ๐ The icon for the more actions button is not visible Active to the must haves since it's a major bug that makes it really hard to find actions besides "Edit".
- ๐ช๐ธSpain ckrina Barcelona
Removing ๐ Integrate Navigation with Contextual editing Active from stable blcokers.
- ๐ช๐ธSpain plopesc Valladolid
Bumping ๐ Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar RTBC to Stable Blocker.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Adding the following recent stable blockers:
- ๐ Local task name expectation in getFeaturedPageActions is fragile Active
- ๐ Show the Navigation Top Bar in 11.1.x and 10.4.x Active
Downgrading priority of โจ Fix safe triangle bottom position. Active to 'Could Have'.
Added the following under Top Bar:
- ๐ navigation top bar edit button has strange active (?) colors Active
- ๐ Navigation top bar overlaps with Olivero menu Active
Replaced ๐ Styling of front theme affects styling of navigation buttons Active with ๐ Front-end theme styles can bleed into Navigation Active
Added the following to 'Should have':
- ๐ฌ๐งUnited Kingdom catch
Just bumping this because the issue summary issue status filter could use a refresh to see what's committed vs. not.
- ๐ฌ๐งUnited Kingdom catch
Moving ๐ Local task name expectation in getFeaturedPageActions is fragile Active to should have. That leaves one current stable blocker, which needs reviews.
- ๐ช๐ธSpain ckrina Barcelona
Removing closed stable blockers (and issues from other sections) to make it easy to parse what's missing.
- ๐ช๐ธSpain ckrina Barcelona
Removing closed stable blockers (and issues from other sections) to make it easy to parse what's missing.
- ๐ช๐ธSpain plopesc Valladolid
Added references to #3516887: Allow to customize Navigation icons โ and ๐ Unchecking the content preview in navigation layout will change the navigation icon to text. Active