Todo for core commit (JS code)

Refactor suggestion here
https://www.drupal.org/project/navigation/issues/3401159 ✨ Refactor components Needs review

We just discussed this with @finnsky and it looks like everything on the summary has been addressed so far:

In the JS all the element selectors should rely on data attributes and not class names, things such as .toolbar-menu__item.toolbar-menu__item--level-2 etc.

This has been done.

There are some syntax issues, ifs that are not wrapped with {}, multiple declarations of variables on one line. essentially the eslint core config should be run on the code and fixed.

I don't have a good solution for that yet, the code could use a refactor to improve readability possibly grouping the positioning into one file/area of the code that sort of things.

After componentizing the CSS and JS and breaking the JS in several files ("no monolithic js anymore" per @finnsky words) we think this is addressed too. The work happened in:

• 📌 Refactor CSS Needs work
• ✨ Refactor components Needs review

Maybe this would need another round to review what needs to happen for core, or otherwise we could close this one.

Adding some JS related issues in the issue summary, on the Should have for now.

Postponing this until we get 📌 Convert jQuery to vanilla Javascript Needs work , so the code will be on a more finished state.

Also updating the issue summary.

Been using the module for a few days, there is a perf issue. Font flashes on every page it's pretty annoying. The initialisation should be done outside of behaviors, that happens too late.

We did a lot of optimisation work on the core toolbar to avoid any flash or layout shift, we should do the same here before getting that in

@nod_ there is an issue for that™ :P 🐛 Flickering when loading the page Needs review . Adding it to the issue summary, thanks!.

Changing title & status since it's active.

Closing this now that ✨ Add the new Navigation to core as an Experimental module Fixed has been opened and all the JS feedback is going to be addressed from there.

Automatically closed - issue fixed for 2 weeks with no activity.