- Issue created by @finnsky
- @finnsky opened merge request.
- Status changed to Needs review
about 1 year ago 8:11am 13 November 2023 - Status changed to Needs work
about 1 year ago 2:19pm 13 November 2023 - πͺπΈSpain ckrina Barcelona
it is ok in terms of BEM:
level - modifier name
2 - modifier value
TIL that you have to do that separation! :D https://en.bem.info/methodology/naming-convention/#two-dashes-style
I've just left a few comments about comments, so moving to NW just for that. Basically, the idea behind those comments is that any newbie (or just somebody without enough context) landing on that file in the future can understand what each part is doing. We don't have external documentation, so we rely on the fields themself to be the documentation itself. Olivero's navigation JS file is a great example: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/oliver...
About the rest, everything makes a lot of sense to me: I personally don't see anything I'd like to change. But it would be great if somebody else could take a look to this, so I'll ping a few people in Slack to see if they can give a quick look to this.
Thanks for the proposal, looks great!
- Status changed to Needs review
about 1 year ago 3:06pm 13 November 2023 - π·πΈSerbia finnsky
I added few comments and simplified js.
I think we may need dedicated ticket about js documentation according core standards. - πͺπΈSpain ckrina Barcelona
This looks good to go for me since it's a net improvement, thanks @finnsky! I'll give some time before merging to see if somebody else finds something worth being improved.
- 2cecbbc2 committed on 1.x
Refactor components - #3401159
- 2cecbbc2 committed on 1.x
- Status changed to Fixed
about 1 year ago 9:31am 15 November 2023 - πͺπΈSpain ckrina Barcelona
OK, time to merge this. Thanks for the work @finnsky!
Automatically closed - issue fixed for 2 weeks with no activity.