- Issue created by @finnsky
- @finnsky opened merge request.
- Status changed to Needs review
9 months ago 9:00pm 10 October 2023 - πͺπΈSpain ckrina Barcelona
We see that in the future such a component will appear in the core of the administrative theme: β¨ Create a new component: Toggletip RTBC .
This is not the same component: the one being proposed to core is a Toggletip. The difference is that a tooltip is exposed on Hover (or Focus) while a toggletip is used on Click or Enter.
Cons: Closing the submenu does not work in the current MP
I tried the submenus on Tugboat and seem to work fine: what am I missing?
- π·πΈSerbia finnsky
RE: `This is not the same component: the one being proposed to core is a Toggletip. The difference is that a tooltip is exposed on Hover (or Focus) while a toggletip is used on Click or Enter.`
I think it is related to component flexibility, `data-toggle-on="hover/click"` etc.
Regression fixed. Temporary for now.
- π·πΈSerbia finnsky
- Rebased on current 1.x
- Added resize observer for trigger.
- Added temporary fix to close cloned flyouts - Status changed to Needs work
9 months ago 12:23pm 20 October 2023 - π«π·France nod_ Lille
Left some comments, not 100% sure about the data-tooltip attribute. the naming is very generic so we might run into problems later, in core we've been prefixing things with drupal, so `data-drupal-tooltip` maybe?
- Status changed to Needs review
9 months ago 12:52pm 20 October 2023 - Status changed to Fixed
9 months ago 1:47pm 20 October 2023 -
nod_ β
committed 08099bc6 on 1.x authored by
finnsky β
Issue #3393067: Added tooltip component.
-
nod_ β
committed 08099bc6 on 1.x authored by
finnsky β
Automatically closed - issue fixed for 2 weeks with no activity.