Flickering when loading the page

This is controlled here.
https://git.drupalcode.org/project/navigation/-/blob/1.x/css/components/...

It was added to:
When label is `collapse-sidebar` and localstorage setting is collapsed then we hide label until js loaded.

We need to add it only for buttons which are sidebar collapse/expand triggers.

Added few optimisations.
Top level menu items looks much better now.

Problem still exists with child menus.

probably we need to move this from js `if (document.URL === link.href) {` to some PHP trick?

Work still needed here.

Removed behaviours usage. now works faster. Please review

Hi
I've tested MR !187 on Drupal 11.x

Test Result: No flickering effect after adding the patch

Adding videos for reference

Keeping in "needs review" for code verification and more reviews

Reviewed the issue. Now the sidebar reloads faster and no flicker found. It looks fixed.
Can be moved to RTBC++
Keeping in Needs Review for further review.

Moving this to NW to get visibility on my comments about the font rendering and font weight changes.

ckrina → closed merge request !187

ckrina → reopened merge request !187

Looks good to me, tested in Firefox, Chrome, and Safari. The JS looks good to me too, always nice to shave off a few ms!

Added comment in MR, please check

I would better reopen follow up for this. Because this MR contains more than this font-display.

I just opened 📌 Decide font-display strategy Active to leave the conversation about the font strategy out of this so we don't block the improvements this is introducing.

Also i found another problem is that "Shortcuts" menu button is not clickable anymore (but contains child menu items, i have checked in devtools). Not sure if it's related to the js rework in this MR. Maybe a follow-up can be opened?

I've just tested this and found the same error, that doesn't happen in 1.x, so the regression is being introduced here. So leaving this as to Needs work to fix that.

it happends because of big-pipe replacement.
shortcut link is initially just link. and child items attached later. but when i removed behaviours this big-pipe replacement happends but no behaviours attached.

you can disable behaviours and check

so question is. revert behaviours or disable big-pipe for navigation somehow?

I've added reattach with behaviours. it works but not sure about it.

Cleaned this a bit more. Now only Big Pipe replaced items became problem. But works.

Alright added extra care about behaviours in case of BigPipe replacements. It is ready to go.

Merged, thanks everybody! This is a great improvement 🎉

Automatically closed - issue fixed for 2 weeks with no activity.