Layout Builder Create Inline blocks logic should be optional

Working on it.

This is not an actual bug, but a feature request.

MR created including test coverage and CR draft created.

Thanks for reporting this @plopesc and doing all the work to get to a resolution.

The need makes sense. We don't want users to be able to add inline blocks to the navigation, it's not designed for that. Blocks for navigation should be very intentional and opt into placement there. I like that we're restricting inline blocks. We were discussing on Drupal Slack whether this is a Navigaton stable blocker. I'm of the opinion that it is, for the reasons just mentioned. I'm marking it as such.

I've tested the resolution and reviewed the code. It all makes sense to me and the tests look good too. I've taken it for a spin on my local, and all looks good. Marking RTBC.

Done a review & there is still a couple of older unresolved threads

Thank you for your review!

I would like to hear the opinions from other folks regarding the open threads, so let's keep it as Needs Review until we have more consensus about the given feedback.

On further conversation in Slack, we'll drop the Navigation stable blocker label, but keep it as a really important nice to have.

Before

After

Probably duplicate screenshots but seems to be a few changes so thought I'd re-upload.

After the MR can see that the Create content block link is no longer there.

Opened up a follow up about refactoring core/modules/layout_builder/tests/src/FunctionalJavascript/InlineBlockTest.php. Believe the rest of this is good, and going to go out on a limb.

Needs a rebase.

Rebased and made some adjustments. I think it needs a new round of reviews to ensure there are no regressions.

Rebase seems fine

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Back to RTBC after rebase.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Back to RTBC after rebase.

Committed/pushed to 11.x, thanks!

catch → closed merge request !10061

There has been no review of the change record for this issue.

I've rewritten some parts, hope it's more clear now. Also updated version to 11.2.0, and catch has published it.