Contrib.social

[META] Migrate Navigation to SDC

Open on Drupal.org →
Created on 1 July 2024, 2 months ago
Updated 15 July 2024, about 2 months ago

Problem/Motivation

SDC is part of core now, so we can migrate the existing code to take advantage of SDC.

Proposed resolution

Plan and move all the components into their own SDCs.

Remaining tasks

The plan for Phase 2 still needs to be defined to refactor and improve the code in the best way possible.

Phase 1 - Create the components

  • 📌 Migrate Toolbar button to SDC Needs review
  • Toolbar menu (todo: create issue)
  • Toolbar block (todo: create issue)
  • Toolbar dropdown (todo: create issue)
  • Toolbar popover (todo: create issue)
  • Tooltip (todo: create issue)
  • Admin Toolbar control bar (todo: create issue)

Phase 2 - Javascript and refactor/improvements/make things right

  • Events
  • Safe triangle refactor
  • Tooltip to core
  • Break the JS into components: @todo a proposal of specific steps and issues

User interface changes

There shouldn't be UI changes.

API changes

Data model changes

Release notes snippet

🌱 Plan
Status

Active

Version

11.0 🔥

Component
Navigation  →

Last updated 1 day ago

No maintainer
Created by

🇪🇸Spain ckrina Barcelona

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ckrina
  • Comment 2 months ago →
    🇪🇸Spain ckrina Barcelona

    Note: I haven’t added as components the following items:

    • Admin Toolbar. I see this more as a region rather than a component
    • Top Bar. Same, I see this more as a a region
    • Body Scroll lock: I see this more as an utility

    I know @finnsky had ideas to plan Phase 2, so leaving this here so he can work on it.

  • Comment about 2 months ago →
    🇳🇿New Zealand quietone New Zealand
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024