Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar

Note that the core issue here (printing menus excluding some links) is mostly taken care of by the approach in ✨ Create a generic system to provide menu based navigation blocks Fixed . Lets postpone this until we finalize direction over there.

@m4olivei is this still needed?

Yep, it is still needed.

To address my last comment, even when ✨ Create a generic system to provide menu based navigation blocks Fixed got in, we didn't change the way that we alter the Administration menu for use in the Navigation bar. We're still using hook_menu_links_discovered_alter, which alters the Administration menu (/admin/structure/menu/manage/admin) in all contexts. For instance, from /admin/structure/menu/manage/admin with and then without navigation module:

Created MR that creates a MenuLinkTree manipulator that triggers an event that gives opportunity to other modules to react to the navigation menu build process.

Created an event subscriber that removes the Help and Content links from admin menu.

Doing it in this way, the original menu is not being altered, and provides an extensible system that allows other modules to interact with the navigation menu link tree.

This is looking good. All remaining threads are resolved. I've just merged 11.x to the branch to freshen it up and see how the pipeline is. Will wait on results and mark RTBC if all is well.

Sad trombone. This is now failing Kernel tests with the following error message:

Drupal\KernelTests\Core\DependencyInjection\AutoconfigurationTest::testCoreServiceTags
Service 'navigation.event_subscriber' in core/modules/navigation/navigation.services.yml should not be tagged with 'event_subscriber'.
Failed asserting that 'event_subscriber' is not equal to 'event_subscriber'.

/var/www/html/core/tests/Drupal/KernelTests/Core/DependencyInjection/AutoconfigurationTest.php:33

Appears to be a new check added in 📌 Enable service autoconfiguration for core event subscribers Fixed . I'll work on the fix.

That was a really straightforward fix per the change record → in 📌 Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar RTBC . Setting to RTBC.

One comment on the MR - I think this could just be an alter hook.

Refactored the approach to use OOP hooks instead of EventSubscribers once 📌 OOP hooks using event dispatcher Needs review is in.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed merge conflicts after 📌 [ignore] Convert everything everywhere all at once Active was merged.

This is looking great to me.

I've tested locally and can confirm that the Help and Content links remain in the Administraton menu with the new approach, and there are no regressions to the Navigation menu.

Thanks for this one @plopesc!

Thanks! Just discovered we face the same issue in dashboard, and this hook will make it easy to fix.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.