Create a generic system to provide menu based navigation blocks

Created on 18 January 2024, 5 months ago
Updated 1 March 2024, 4 months ago

Problem/Motivation

We currently have 2 navigation blocks based on menus (ContentNavigationBlock & AdminNavigationBlock).

Both classes are pretty similar and only a few bits are different.

A more advanced solution would be to create a deriver that generates the navigation blocks for all the existing menus, similar to SystemMenuBlock.

Steps to reproduce

Proposed resolution

Create a Generic menu based navigation block plugin and a deriver that automatically provides navigation blocks for the different menus in the system

Get rid of the menu-specific already existing implementations.

Remaining tasks

Write POC
Validate it

User interface changes

API changes

Data model changes

Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • 🇪🇸Spain plopesc Valladolid
  • Assigned to plopesc
  • 🇪🇸Spain plopesc Valladolid
  • 🇪🇸Spain plopesc Valladolid
  • 🇨🇦Canada m4olivei Grimsby, ON

    This has come up in the past. Personally, I'm a fan of the deriver plugin approach. I think it provides a lot of flexibility for sites that really want to take control of their sidebar which would be really neat.

    One thing we'll have to address, (which we have to do now anyway), is a better visual icon fallback than we currently have when the CSS class doesn't match up with what we already support. You can see that already with the Announcements menu item, which I think was added in 10.2. That can be a seperate issue though.

  • Pipeline finished with Failed
    5 months ago
    Total: 145s
    #79790
  • Pipeline finished with Failed
    5 months ago
    Total: 168s
    #79792
  • Pipeline finished with Success
    5 months ago
    Total: 179s
    #79813
  • Pipeline finished with Success
    5 months ago
    Total: 185s
    #79816
  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    @m4olivei went ahead and worked on a POC for the deriver approach.

    Now, every menu has automatically created its own configurable navigation blocks.

    This configuration allows to exclude items, so big part of the concerns in 📌 Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar Active could be addressed in this issue.

  • 🇨🇦Canada m4olivei Grimsby, ON

    So good! I'll leave the issue as Needs Review for others to take a look as well, as it's a decent size change, and their might be opinions.

  • Status changed to Needs work 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON
  • Pipeline finished with Canceled
    5 months ago
    #80196
  • Pipeline finished with Canceled
    5 months ago
    Total: 23s
    #80197
  • Pipeline finished with Success
    5 months ago
    Total: 147s
    #80198
  • Pipeline finished with Success
    5 months ago
    Total: 199s
    #80199
  • Pipeline finished with Success
    5 months ago
    Total: 184s
    #85481
  • Pipeline finished with Success
    5 months ago
    Total: 150s
    #85843
  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    Logic to exclude items dynamically from the navigation block config has been removed, as agreed on weekly call.

    Discussion about how to exclude items in a generic and non-intrusive way can be moved to #3415572

  • Status changed to Needs work 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Just a few small things to address. See MR threads.

  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    Thank you for your feedback @m4olivei!

    I think it has been addressed. Please take a look again once you get the chance.

  • Status changed to Needs work 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    @plopesc Hum, I don't see new commits? Last commit was Feb 1. Maybe you forgot to push them up?

  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    Yes, you were right.

    Hit enter, but did not check if the operation was successful. It should be there now.

    Sorry for the inconvenience.

  • Pipeline finished with Success
    5 months ago
    Total: 232s
    #89325
  • Pipeline finished with Success
    4 months ago
    Total: 145s
    #96627
  • Status changed to Fixed 4 months ago
  • 🇪🇸Spain ckrina Barcelona

    Merged!

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    3 months ago
    Total: 54s
    #134467
  • Pipeline finished with Success
    3 months ago
    Total: 52s
    #134476
  • Pipeline finished with Success
    3 months ago
    Total: 63s
    #134488
  • Pipeline finished with Success
    3 months ago
    #134482
  • Pipeline finished with Success
    3 months ago
    Total: 314s
    #134502
  • Pipeline finished with Success
    3 months ago
    Total: 1137s
    #135092
  • Pipeline finished with Success
    3 months ago
    Total: 51s
    #136151
  • Pipeline finished with Success
    3 months ago
    Total: 410s
    #138411
  • Pipeline finished with Success
    3 months ago
    Total: 52s
    #138536
  • Pipeline finished with Success
    3 months ago
    Total: 362s
    #140731
  • Pipeline finished with Canceled
    3 months ago
    Total: 28s
    #140879
  • Pipeline finished with Success
    about 1 month ago
    Total: 859s
    #178659
  • Pipeline finished with Success
    about 1 month ago
    Total: 835s
    #178660
  • Pipeline finished with Success
    23 days ago
    Total: 865s
    #192742
  • Pipeline finished with Success
    12 days ago
    Total: 135s
    #200760
  • Pipeline finished with Success
    12 days ago
    Total: 136s
    #200766
Production build 0.69.0 2024