- Issue created by @plopesc
- Assigned to plopesc
- 🇨🇦Canada m4olivei Grimsby, ON
This has come up in the past. Personally, I'm a fan of the deriver plugin approach. I think it provides a lot of flexibility for sites that really want to take control of their sidebar which would be really neat.
One thing we'll have to address, (which we have to do now anyway), is a better visual icon fallback than we currently have when the CSS class doesn't match up with what we already support. You can see that already with the Announcements menu item, which I think was added in 10.2. That can be a seperate issue though.
- Merge request !167Resolve #3415576 "Create menu navigation block deriver" → (Merged) created by plopesc
- Status changed to Needs review
10 months ago 11:25am 19 January 2024 - 🇪🇸Spain plopesc Valladolid
@m4olivei went ahead and worked on a POC for the deriver approach.
Now, every menu has automatically created its own configurable navigation blocks.
This configuration allows to exclude items, so big part of the concerns in 📌 Adjust how Help link and Content links are removed from the Administration menu for the Navigation bar RTBC could be addressed in this issue.
- 🇨🇦Canada m4olivei Grimsby, ON
So good! I'll leave the issue as Needs Review for others to take a look as well, as it's a decent size change, and their might be opinions.
- Status changed to Needs work
10 months ago 3:13am 20 January 2024 - Status changed to Needs review
10 months ago 7:26am 1 February 2024 - 🇪🇸Spain plopesc Valladolid
Logic to exclude items dynamically from the navigation block config has been removed, as agreed on weekly call.
Discussion about how to exclude items in a generic and non-intrusive way can be moved to #3415572
- Status changed to Needs work
10 months ago 3:06am 6 February 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Just a few small things to address. See MR threads.
- Issue was unassigned.
- Status changed to Needs review
10 months ago 4:33pm 6 February 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for your feedback @m4olivei!
I think it has been addressed. Please take a look again once you get the chance.
- Status changed to Needs work
10 months ago 3:59am 7 February 2024 - 🇨🇦Canada m4olivei Grimsby, ON
@plopesc Hum, I don't see new commits? Last commit was Feb 1. Maybe you forgot to push them up?
- Status changed to Needs review
10 months ago 6:23am 7 February 2024 - 🇪🇸Spain plopesc Valladolid
Yes, you were right.
Hit enter, but did not check if the operation was successful. It should be there now.
Sorry for the inconvenience.
- Status changed to Fixed
9 months ago 11:20am 16 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.