- Issue created by @ckrina
- 🇪🇸Spain ckrina Barcelona
This was initially discussed in Slack and got the +1 from @nod_, @finnsky and @starshaped. @mherchel had concerns on how this could affect the current themes from core using it, like Claro and Olivero, because the dependencies wouldn't match:
The thing is that we have postcss-px-to-rem in core
And since this is going into core, we want the dependencies to match, right?
If we yank it out of navigation, we'll need to somehow accommodate it when adding it into core. That might not be too easyI personally don't think this be any problem since we're working on a module. Plus in my opinion, the least postcss plugins we use the better.
- First commit to issue fork.
- Merge request !8021removed pcss px-to-rem conversion for navigation → (Open) created by Unnamed author
- Status changed to Needs review
8 months ago 2:04pm 10 May 2024 - Status changed to Needs work
8 months ago 10:05pm 10 May 2024 - 🇷🇺Russia kostyashupenko Omsk
I think we have to keep rems.
Themes and modules can conrol everything by overriding
--admin-toolbar-rem
variable, no?