- Issue created by @finnsky
- Status changed to Needs review
3 months ago 7:59am 13 March 2024 - 🇪🇸Spain ckrina Barcelona
Commenting here also what I've mentioned in Slack for the record: I’m actually wondering if we should really be using postcss-px-to-rem and just write the code with the unit it needs and get rid or auto-conversions. IMHO our code is small enough to control that.
- 🇷🇸Serbia finnsky
@ckrina i think we need to merge this small fix,
because `yarn build` now always generate that 1rem-1rem :)And probably reopen discussion ticket
- Status changed to Fixed
3 months ago 9:55am 15 March 2024 - 🇪🇸Spain ckrina Barcelona
Fixed, thanks @finnsky! I've also added a comment next to it so it's obvious why it's there and opened 📌 Remove postcss-px-to-rem from Navigation Active .
@rishabjasrotia thank you for your interest in working on this issue.
This issue works with a merge request (MR), so posting additional patches (especially with the same code) is not helpful. In general, patches should be avoided from now on.
In the future, you can get credit for issues by reading the issue to understand its purpose, and taking into account all the discussion on the issue. More information on the issue credit guidelines → . Thanks! Hello @finnsky it is the same code patch added until issue was not merged to be used.
Automatically closed - issue fixed for 2 weeks with no activity.