Status warning: Toolbar and Navigation modules are both installed

Just to add, that if the gin_toolbar + toolbar are enabled together with the navigation module, there are conflicts in the admin menu displayed (different icons, some are missing - like the trash icon, different icon's weights, ...). See the images (the first is with the toolbar enabled and second with toolbar disabled).

vs

This definitely needs sign-off from @saschaeggi.

I’d go so far as to say that getting sign-off (and, if you get it, implementing this change) is a stable release blocker.

Currently it's not possible to disable toolbar as the topbar navigation is not fully implemented in core.

Removing toolbar will break Gin functionality for the time being.

Also Gin Toolbar will potentially never be removable as it provides features which a theme can't do - where we need a module for (e.g. exposing styles to the frontend).

Closing for now as won't fix until topbar reaches beta+.

PS: The trash icon was recently fixed with another issue.

Ok then, so let's focus on the warning message. Site owners will see the message and will eventually disable it by themselves according to the instructions in the warning. Then it will (potentially) break according to the #7. Should be remove the warning from the status report?

Why would core put the message into to navigation_requirements if it still didn't fully work? Is this is Gin theme issue? Thanks!

I think there are more options how to handle this, but not sure which will be the ideal one.

We can create a core issue for this, to temporarily remove the warning (if such an issue does not exists yet). Or can Gin probably remove that warning using hook_requirements_alter (if the issue is mostly with the gin_toolbar)? Or we can do this in Drupal CMS, but not sure there is an easy way to do it.

I agree we should suppress it. I think Gin would have to do this, don't think we have a mechanism for it in Drupal CMS, and core won't want to because it's a valid warning if you're not using Gin.

Although the warning is confusing, I don't think this is a stable release blocker. I've created a new tag for release targets.

Can somebody spin up an MR so we can temporarily remove this warning until we have the navigation topbar ready? Thanks 🙇

I have created an issue 🐛 Temporarily suppress toolbar & navigation warning Needs review on gin_toolbar and a MR to do this.

Looks good to me! This removes the warning as expected.

saschaeggi → changed the visibility of the branch 3489361-Status-warning-modules-are-both-installed to hidden.

saschaeggi → changed the visibility of the branch 3489361-status-warning-toolbar to hidden.

Fixed via 🐛 Temporarily suppress toolbar & navigation warning Needs review