🇳🇱Netherlands @robertragas

Account created on 11 October 2013, over 11 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands robertragas

I want to add to this issue that I'm still facing this on Drupal Core 10.3, but also on the dev version

Maybe that my HTT can help in reproducing it, as it seems to be depending on how you install the modules.

Requirements:
- ai on 1.1.x-dev with datestamp 1741688380 (which is the latest dev release on the releases page speaking of now)
- ai_search (comes with the ai)
- ai_vdb_provider_milvus on 1.0.0-beta2 (note that I had to change the vectorSearch method in MilvusProvider.php line 597 otherwise the method is not compatible with the base method that I guess changed in the dev version of AI).

HTT
1. Enable the ai module
2. Browse to your platform -> login -> and create a key for your zilliz.
3. Enable ai_vdb_provider_milvus (which also enables the sub-dependency ai_search)
4. Navigate to the milvus page on /admin/config/ai/vdb_providers/milvus
5. Fill in the information and submit to see the error message

Extra note:
If I would enable ai_vdb_provider_milvus from the start where it would automatically install it's dependencies then it would work correctly.

🇳🇱Netherlands robertragas

Added patch that we can use.

🇳🇱Netherlands robertragas

+1 Also ran into this issue where we don't have role mapping enabled, but the role_mappings config not being an empty array and overriding on login.

Saving the form does not help, but after changing the config manually it works again.

🇳🇱Netherlands robertragas

robertragas made their first commit to this issue’s fork.

🇳🇱Netherlands robertragas

robertragas made their first commit to this issue’s fork.

🇳🇱Netherlands robertragas

Moving it to RTBC so we can hopefully get it merged to avoid using patches.

🇳🇱Netherlands robertragas

This caused some regression in the member block on the homepage and in group member block.

🇳🇱Netherlands robertragas

robertragas made their first commit to this issue’s fork.

🇳🇱Netherlands robertragas

Ah, I missed a patch, looking into it.

🇳🇱Netherlands robertragas

Should be in 3.0.6 and moving towards solely Address v2 to reflect upcoming changes in the Open Social 13
https://github.com/goalgorilla/open_social/pull/4140

🇳🇱Netherlands robertragas

Added a patch from the merge-request with the changes:
- autowiring the access_check.role_delegation service (not sure if we wanted to set default to true for all).
- Set update hook setting to TRUE to avoid regression for existing sites.

But main reason for adding the patch is because I need a static patch file that I can use instead of a merge request that can change.

🇳🇱Netherlands robertragas

Thanks for the work! We also ran into the issue and this looks good but would also like to have update hook set to yes to avoid the regression.

🇳🇱Netherlands robertragas

You are lightning fast socialnicheguru! Also wanted to take a look into it today. Thanks, I will merge it an make a new release.

🇳🇱Netherlands robertragas

Releasing 12.4.8 with a fix for this now https://git.drupalcode.org/project/social/-/commit/d8a89fc7ea4d5e96c72de...

Feel free to re-open if you still run into issues.

🇳🇱Netherlands robertragas

Combined patches for

"Issue #2761187/#3386579 Improve how the module deals with non-embeddable URLs & WSODs (See: https://www.drupal.org/project/social/issues/3386579#comment-15225972 🐛 Non-embeddable links disappear in comments and post (updated patch for url_embed 2.x) Fixed ) 2.x": " https://www.drupal.org/files/issues/2023-09-22/urlembed-non-embeddable-u... "

and

"Issue #3386590: preg_split in _filter_url breaks for long html tags": " https://www.drupal.org/files/issues/2023-09-11/3382821-url_embed-preg-sp... "

🇳🇱Netherlands robertragas

This should be fixed in the new 12.4.6

🇳🇱Netherlands robertragas

Hello slowflyer,

I am currently working on it.

🇳🇱Netherlands robertragas

Hello dianacastillo,

We are trying to remove the getFieldValue from our codebase. I wonder though how your composer.json file looks like.
If you look at the codebase for version 12.4.5 which you can see here https://git.drupalcode.org/project/social/-/blob/12.4.5/composer.json?re... you can see we have applied a patch to drupal/core that add the getFieldValue method.
"Optimize getCommentedEntity()": "https://www.drupal.org/files/issues/2018-12-28/2580551-72.patch",

Could it be that in your codebase this patch is not added or not applying anymore?

🇳🇱Netherlands robertragas

Updated the patch as the word-break part was already added in another commit.

Production build 0.71.5 2024