🇳🇱Netherlands @robertragas

Account created on 11 October 2013, over 10 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands robertragas

Merged and will be landing in 12.3.6 and up.

🇳🇱Netherlands robertragas

Ready for review, added some css for word-breaks.

🇳🇱Netherlands robertragas

PR open where I adjusted the config override to be valid again.
Also I removed duplicated code where the same filter was added for both views while this could just be done in the default.

🇳🇱Netherlands robertragas

Merged and will be landing in 3.0.3 as solr in social_search landed in OS 13+

🇳🇱Netherlands robertragas

Merged and will be landing in
3.0.3 and 2.5.2

🇳🇱Netherlands robertragas

Landing in 2.1.8 and 2.0.10

🇳🇱Netherlands robertragas

I have been able to consistently reproduce it by having a destination parameter in the url, once you press on the login with o365 button you will already get it before even returning from the azure login.

If you would remove that the error is not present.

🇳🇱Netherlands robertragas

I have created a merge request where we are moving towards localstorage. This is also adds support to get the pop-up to use the app on multiple devices. As currently it stores the prompt in the database for the specific user, so even if you switched devices you would not get the pop-up.

🇳🇱Netherlands robertragas

Also having the same issue when upgrading from 3.x to 5.0.7

🇳🇱Netherlands robertragas

Merged and released in 2.1.6 and 2.0.8

🇳🇱Netherlands robertragas

Merged and released in 4.1.3.

The subissue with kpi_analytics also has been solved in a new version there.

🇳🇱Netherlands robertragas

Merged and released in 3.1.2

🇳🇱Netherlands robertragas

robertragas made their first commit to this issue’s fork.

🇳🇱Netherlands robertragas

Thank SocialNicheGuru! Will incorporate your fix with it.

🇳🇱Netherlands robertragas

Merged and released to 2.5.1

🇳🇱Netherlands robertragas

Merged and released in 5.1.6 and 5.2.4

🇳🇱Netherlands robertragas

Merged and will be landing in 2.0.7 and 2.1.5

🇳🇱Netherlands robertragas

Ready for review. I altered the Push Activity Sender to make sure it can also handle arrays, as we already got the correct users but it only took the first user.

🇳🇱Netherlands robertragas

Merged and will be landing in 2.0.6 and 2.1.4

🇳🇱Netherlands robertragas

By now this has been changed to 9 || 10 so this change is not needed anymore, so setting it to fixed and will credit you both for the work.

🇳🇱Netherlands robertragas

Added a patch to fix this issue. Issue was that this pop-up was calling the removal endpoint instead of adding.

🇳🇱Netherlands robertragas

Merged and will be landing in 2.0.6 and 2.14.

🇳🇱Netherlands robertragas

Attached a patch where I have rewritten the method for opening the url.
There is something going wrong there in opening the url. It's rewritten now as also written in the official documentation
https://developer.mozilla.org/en-US/docs/Web/API/Clients/openWindow

Tested this on android/ios and both are now working correctly.

🇳🇱Netherlands robertragas

PR
https://github.com/goalgorilla/open_social/pull/3851

With added checks to make sure to only execute it when the view has been corrupted.

🇳🇱Netherlands robertragas

Approved and merged. Will be landing in 12.3.3 and up.

🇳🇱Netherlands robertragas

Approved and merged, will be landing in 12.4.0 and up.

🇳🇱Netherlands robertragas

Approved and merged. Will be landing in 12.3.3 and up/

🇳🇱Netherlands robertragas

Landing in 2.5.7 and up.

Production build 0.69.0 2024