robertragas → made their first commit to this issue’s fork.
Ah, I missed a patch, looking into it.
Should be in 3.0.6 and moving towards solely Address v2 to reflect upcoming changes in the Open Social 13
https://github.com/goalgorilla/open_social/pull/4140
Thanks for the patch! Github PR can be found here
https://github.com/goalgorilla/open_social/pull/4245
+1
Tested and works great, thanks!
robertragas → created an issue.
Added a patch from the merge-request with the changes:
- autowiring the access_check.role_delegation service (not sure if we wanted to set default to true for all).
- Set update hook setting to TRUE to avoid regression for existing sites.
But main reason for adding the patch is because I need a static patch file that I can use instead of a merge request that can change.
Thanks for the work! We also ran into the issue and this looks good but would also like to have update hook set to yes to avoid the regression.
I believe they already fixed this in version 2.4
https://www.drupal.org/project/content_lock/issues/3307402
🐛
Content Lock should typehint ModuleHandler interface rather than a specific implementation
Fixed
You are lightning fast socialnicheguru! Also wanted to take a look into it today. Thanks, I will merge it an make a new release.
Releasing 12.4.8 with a fix for this now https://git.drupalcode.org/project/social/-/commit/d8a89fc7ea4d5e96c72de...
Feel free to re-open if you still run into issues.
Combined patches for
"Issue #2761187/#3386579 Improve how the module deals with non-embeddable URLs & WSODs (See: https://www.drupal.org/project/social/issues/3386579#comment-15225972 🐛 Non-embeddable links disappear in comments and post (updated patch for url_embed 2.x) Fixed ) 2.x": " https://www.drupal.org/files/issues/2023-09-22/urlembed-non-embeddable-u... → "
and
"Issue #3386590: preg_split in _filter_url breaks for long html tags": " https://www.drupal.org/files/issues/2023-09-11/3382821-url_embed-preg-sp... → "
robertragas → created an issue.
This should be fixed in the new 12.4.6
Hello slowflyer,
I am currently working on it.
Hello dianacastillo,
We are trying to remove the getFieldValue from our codebase. I wonder though how your composer.json file looks like.
If you look at the codebase for version 12.4.5 which you can see here https://git.drupalcode.org/project/social/-/blob/12.4.5/composer.json?re... you can see we have applied a patch to drupal/core that add the getFieldValue method.
"Optimize getCommentedEntity()": "https://www.drupal.org/files/issues/2018-12-28/2580551-72.patch",
Could it be that in your codebase this patch is not added or not applying anymore?
PR
https://github.com/goalgorilla/open_social/pull/4127
and got approved and merged for alpha17
robertragas → created an issue.
robertragas → created an issue.
robertragas → created an issue.
kingdutch → credited robertragas → .
Updated the patch as the word-break part was already added in another commit.
robertragas → created an issue.
Closing as we don't support 2.1.x anymore.
Closing as we don't support 2.2.x anymore.
Closing this one as we don't support 2.3.x anymore.
I also made some small improvement for the width when you have 3 columns that it would touch the edge. I used container sizes for this
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_containment/Contain...
because breakpoints on viewport width don't work and therefore need the container sizes to hide elements when it's a certain width.
Before the change
After the change
robertragas → created an issue.
PR
https://github.com/goalgorilla/open_social/pull/4067
Approved and merged.
Will be landing in 13.0.0-alpha13
robertragas → created an issue.
robertragas → created an issue.
landing in 13.0.0-alpha12
Landing in 13.0.0-alpha12
Landing in 13.0.0-alpha12
Landing in 13.0.0-alpha12
Landing in 13.0.0-alpha12
robertragas → created an issue.
PR opened. Note that it has to be combined with Open Social Distro change that I will be posting later today.
robertragas → created an issue.
Looks good
Should be fixed now by using socialbase 2.6.4