Patch for views_ef_fieldset broken by dynamic url

Created on 6 November 2024, 28 days ago

Problem/Motivation

Hi,

The composer file in the 12.4.x branch points to 3 merge_requests as patches.

And someone decided to work on one of them yesterday ... making it incompatible with the current stable version 1.8.0.

Steps to reproduce

$ composer install

...

  - Applying patches for drupal/views_ef_fieldset
    https://git.drupalcode.org/project/views_ef_fieldset/-/merge_requests/1/diffs.patch (Issue #3173822: Exposed operators are not included in fieldsets)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/views_ef_fieldset/-/merge_requests/1/diffs.patch

In Patches.php line 331:
                                                                               
  Cannot apply patch Issue #3173822: Exposed operators are not included in fieldsets (https://git.drupalcode.org/project/views_ef_fieldset/-/merge_requests/1/diffs.patch)!                                                          
                                                                               

The composer.lock file would hold on to the 1.0.8 version which no longer matches with the MR.

Calling `composer update` resolves this by bumping the module to 1.0.9. But the current version of our site is nolonger deployable.

Proposed resolution

The advise is usually to not use a dynamic url for matches, but something stable as a commit hash or a patchfile linked in an issue comment.

Remaining tasks

  • Update the 3 patches for views_ef_fieldset
🐛 Bug report
Status

Active

Version

12.4

Component

Other

Created by

🇳🇱Netherlands helmo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @helmo
  • 🇯🇵Japan ultrabob Japan

    This has broken our deploys for open_social as well, and I'm not sure how we could go about fixing it.

    I'm not sure what the latest compatible version of views_ef_fieldset is. I've seen an issue saying that 8.1.10 is incompatible, so it is hard to construct a replacement patch, but even then, I'm not sure if we can patch the open_social composer.json.

    As helmo points out, Gitlab patches should never be linked because they tend to disappear like this one did.

  • 🇯🇵Japan ultrabob Japan

    For me, locking the module to 1.10 and adding this to my composer.json seems to get it to ignore the problematic patch.

        "patches-ignore": {
          "goalgorilla/open_social": {
            "drupal/views_ef_fieldset": {
              "Issue #3173822: Exposed operators are not included in fieldsets": "https://git.drupalcode.org/project/views_ef_fieldset/-/merge_requests/1/diffs.patch"
            }
          }
        },
  • 🇳🇱Netherlands robertragas

    This should be fixed in the new 12.4.6

Production build 0.71.5 2024