[Meta] Symfony 7 compatibility

I'm going to bump this to major since there is a kinda time-sensitive request in the Symfony IS for dependent frameworks to determine if there are particular types that will be hugely problematic. There are instructions, and I think this should be easy enough to do in GitLab CI.

Closing as a duplicate of 📌 Update to Symfony 6.4 Needs work

Not a duplicate.

The following dependencies need to declare Symfony 7 compatibility:

• asm89/stack-cors - pull request at https://github.com/asm89/stack-cors/pull/104
• behat/mink - support is in master but not a tagged release
• behat/mink-browserkit-driver
• mglaman/phpstan-drupal

@longwave, thanks.

I've moved the list of upstream changes to the Issue Summary and added a link for the behat/mink-browserkit-driver issue.

Merged https://github.com/mglaman/phpstan-drupal/pull/639 – I just want to wait a few days to release phpstan-drupal as I cut 1.2.3 this morning, right before the issue was filed.

I have a pipeline running on Symfony 7 over in a test issue, where almost all the tests are passing with a handful of changes to core - need to break those out into separate issues so we can decide what to do with them in 10.x and 11.x but overall it's looking quite good to me: https://git.drupalcode.org/project/drupal/-/pipelines/49497/test_report

Updated IS a bit with current state

https://github.com/asm89/stack-cors/releases/tag/v2.2.0 is out as well as SF 6.4.0/7.0.0

Only behat/mink* is not ready (as always)

ordering to IS points

mink merged changes to master so only tagged releases left

asm89/stack-cors will be included in 📌 Update dependencies for Drupal 10.2 Needs review

mglaman/phpstan-drupal needs bump constraint s/1.2.1/1.2.4

SF7 compatibility will require composer 2.7 https://github.com/composer/composer/issues/11741#issuecomment-1847572878

composer 2.6.6 apparently resolves https://github.com/composer/composer/issues/11741#issuecomment-1847572878 so we might be able to just update to that instead of waiting for 2.7.

It resolving conflict st least so let's upgrade

The list of tasks is incomplete, there are more than those listed.

https://git.drupalcode.org/project/drupal/-/merge_requests/5388 is an old work in progress MR that has some more SF7 fixes in it.

https://github.com/symfony/symfony/releases/tag/v7.0.3

Composer released https://github.com/composer/composer/releases/tag/2.7.0

Pushed a YOLO! commit to the MR, just with the updated dependencies, now that all external dependencies are SF7 ready.

As PHPStan shows (and @longwave already said in #21 📌 Symfony 7 compatibility Active ): The list of tasks is incomplete, there are more than those listed.

A lot of wheels are already in motion to get rid of the "last" SF6.4 issues, for Behat and friends there's an issue somewhere, and there are bound to be more issues floating around.

Spokje → closed merge request !6514

Spokje → changed the visibility of the branch 11.x to hidden.

New MR, either me or GitLab couldn't figure out a rebase on the previous one (yeah, prob me...).

Not much to see until 📌 [11.x] Add void returns for Symfony 7 RTBC lands.

📌 [11.x] Add void returns for Symfony 7 RTBC is for the 11.x codebase only, so it cannot be committed right now. Are there any other changes to be made on "the 10.3.x branch" for Symfony 7 or none left?

Some of the ContainerAware removals will likely also be committed to 10.3.x as they will involve deprecations. It's hard to see the full picture without clearing the void returns and ContainerAware issues first, there may be more we need to do after that that also involve adding deprecations to 10.3.x.

Rebased the MR.

Before the rebase:

88 errors

After the rebase:
62 errors

Rebased and bumped symfony/* to 7.0.4.
After the rebase:
58 errors

Rebased and bumped symfony/* to 7.0.5.
After the rebase:
58 errors

One existing issue reparented and two new child issues to handle Symfony Validator issues that are picked up here:

📌 Symfony deprecations in Constraint plugins Active
📌 Overwrite Symfony constraint errors in constructors instead of properties Active
📌 Remove $context properties from ConstraintValidators Active

Rebased: Found 23 errors

Whoops, your push wasn't there when I started my own rebase, and then I repeated and overwrote your work, sorry!

No worries, as long as the end result is less errors :)

Rebase again following two more commits, down to 10 errors.

needs rebase/fixes

Down to 7 PHPStan errors

Opened 📌 Notify downstream users that ContainerAware is going away Needs review which if accepted means 📌 Fork Symfony's ContainerAwareTrait and ContainerAwareInterface into core Needs work is won't fix.

Spokje → closed merge request !6594

Spokje → changed the visibility of the branch 3394694-sf7 to hidden.

Urgh, that was no fun to figure out. See #3054535-37: Discuss whether to decouple from Symfony Validator → for the backstory on 95a33fe4.

A green pipeline on Symfony 7!

Only a few BaseFieldDefinition tweaks needed, will open another issue to backport those; was surprised that translated constraint errors didn't break, but it appears we have test coverage and all is good.

Raised https://github.com/symfony/symfony/issues/54321 as there is a type error in Symfony that we currently work around here, unsure which way they will fix this.

https://github.com/symfony/symfony/issues/54321 was fixed so once Symfony 7.0.6 is out we can revert the change around Request::setFactory().

Last child issue can be marked fixed 📌 [META] Reduce use of ContainerAware classes where possible Active as commited 📌 [PP-2] Remove support for ContainerAwareInterface Postponed and remaining is no longer a blocker 📌 Inject services into LoggerChannelFactory RTBC

No blockers, needs work for upgrade issue

Think 📌 [11.x] [PP-1] Add PHP 8.3 requirement to Drupal 11.0.x Postponed needs to be done first as it will set PHP to 8.3 min.

PHP 8.2 is the minimum for SF 7, so not really a hard blocker.

However the release of SF 7.0.6 is, if we want to prevent using workarounds (as said by @longwave in #52 📌 Symfony 7 compatibility Active )

Spokje → closed merge request !7066

Spokje → changed the visibility of the branch 3394694-sf7-no-containeraware-less-rebases to hidden.

Opened 📌 [PP-1] Update to Symfony 7.0 Postponed to actually do the update, we must do 📌 [11.x] [PP-1] Add PHP 8.3 requirement to Drupal 11.0.x Postponed first and we have a Validator component problem to sort out as well which probably should be its own issue.

Out there in 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Needs work there are still a lot of DebugClassloader deprecations for Symfony 7 typehints, see https://git.drupalcode.org/issue/drupal-3417066/-/pipelines/127550 and its test jobs.

For some reason 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Needs work seems to be stricter than current symfony-bridge in reporting deprecations triggered before the test start.

Example:

 PHPUnit 10.5.14 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.3.4
    Configuration: /builds/issue/drupal-3417066/core/phpunit.xml.dist
    
    D                                                                   1 / 1
    (100%)
    
    Time: 00:00.843, Memory: 16.00 MB
    
    1 test triggered 15 deprecations:
    
    1)
    /builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
    Method
    "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
    might add "void" as a native return type declaration in the future. Do the
    same in implementation
    "Drupal\Core\DependencyInjection\Compiler\ModifyServiceDefinitionsPass" now
    to avoid errors or add an explicit @return annotation to suppress this
    message.
    
    Triggered by:
    
    *
    Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
     
    /builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
    
    2)
    /builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
    Method
    "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
    might add "void" as a native return type declaration in the future. Do the
    same in implementation
    "Drupal\Core\DependencyInjection\Compiler\DevelopmentSettingsPass" now to
    avoid errors or add an explicit @return annotation to suppress this
    message.
    
    Triggered by:
    
    *
    Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
     
    /builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
    
    3)
    /builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
    Method
    "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
    might add "void" as a native return type declaration in the future. Do the
    same in implementation
    "Drupal\Core\DependencyInjection\Compiler\CorsCompilerPass" now to avoid
    errors or add an explicit @return annotation to suppress this message.
    
    Triggered by:
    
    *
    Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
     
    /builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
    
    4)
    /builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
    Method
    "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
    might add "void" as a native return type declaration in the future. Do the
    same in implementation
    "Drupal\Core\DependencyInjection\Compiler\StackedSessionHandlerPass" now to
    avoid errors or add an explicit @return annotation to suppress this
    message.
    
    Triggered by:
    
    *
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
5)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\Render\MainContent\MainContentRenderersPass" now to avoid
errors or add an explicit @return annotation to suppress this message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
6)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\RegisterStreamWrappersPass" now
to avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
7)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\TwigExtensionPass" now to avoid
errors or add an explicit @return annotation to suppress this message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
8)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\RegisterEventSubscribersPass" now
to avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
9)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\RegisterAccessChecksPass" now to
avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
10)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\RegisterServicesForDestructionPass"
now to avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
11)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation "Drupal\Core\Cache\ListCacheBinsPass" now to avoid
errors or add an explicit @return annotation to suppress this message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
12)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation "Drupal\Core\Cache\Context\CacheContextsPass" now to
avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
13)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation "Drupal\Core\Plugin\PluginManagerPass" now to avoid
errors or add an explicit @return annotation to suppress this message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
14)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()"
might add "void" as a native return type declaration in the future. Do the
same in implementation
"Drupal\Core\DependencyInjection\Compiler\DeprecatedServicePass" now to
avoid errors or add an explicit @return annotation to suppress this
message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 
/builds/issue/drupal-3417066/core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelSiteTest.php:18
15)
/builds/issue/drupal-3417066/vendor/symfony/error-handler/DebugClassLoader.php:337
Method
"Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents()"
might add "array" as a native return type declaration in the future. Do the
same in implementation "Drupal\Core\Update\UpdateRegistry" now to avoid
errors or add an explicit @return annotation to suppress this message.
Triggered by:
*
Drupal\KernelTests\Core\DrupalKernel\DrupalKernelSiteTest::testServicesYml
 

Most of it should be fixed by related rector to prevent manual intervention, the scariest is how contrib will adopt it...

Filed 📌 Fix return typhinting for Compiler related classes Active for #61

Spokje → closed merge request !7153

📌 [PP-1] Update to Symfony 7.0 Postponed landed, so we are all done here - thanks to everyone who contributed especially @Spokje for keeping on top of this.

Automatically closed - issue fixed for 2 weeks with no activity.