[11.x] Add void returns for Symfony 7

Needless to say this is for 11.x only.

Unhappy PHPStan

Hm, maybe the debug class loader isn't working like I thought, because we should have been notified already about these subclasses?

, because we should have been notified already about these subclasses?

Not sure I follow.

In the MR we added return types where none where there before, now PHPStan complains some sub-classes have defined types that aren't covariant with the newly defined ones.

How could we be warned before we added the return types on the "super" classes?

Re #7 e.g. AllowedValuesConstraintValidator::validate() extends a Symfony validator that was tagged @return void in Symfony 6. But I guess if we have no test coverage of this, then we won't trigger the deprecation.

But then what about SupernovaGenerator::setContext(), which is part of a test - wonder if this is just because the inheritance chain is more complicated, but ultimately setContext() belongs to a Symfony interface method that was also tagged @return void.

Wasn't sure how best to find others.

Did a search for phpcs:ignore Drupal.Commenting.FunctionComment.VoidReturn and all instances have been removed in core. Tests are green so leaning on that.

This seems like a small enough change to mark without having to wait a week.

Rebase. Only conflict was in DrupalKernel.php and it was straightforward to fix.

I'm not too concerned about missing some - things will crash if we do and we can fix.

Committed f4167b8 and pushed to 11.x. Thanks!

quietone → closed merge request !5748

Automatically closed - issue fixed for 2 weeks with no activity.