Overwrite Symfony constraint properties in constructors instead of child properties

One comment, otherwise looks good.

Thanks for review, didn't spot that - fixed.

Whoops, turns out I missed RegexValidator and the deprecation skip removal caught that. Thanks again!

Looks like ExtensionNameConstraint extends RegexConstraint and is passing in a string to the constructor, causing the tests to fail.

So RegexConstraint doesn't need the message anyway, because the default message upstream is the same - I removed the constructor entirely there.

Subclasses of the other constraints will run into the same issues, so I think a more correct way is to overwrite the default properties before calling the parent constructor, and always pass all arguments through. Applied this to the other constraints.

Should RangeConstraint be changed similarly?

Was wondering that, and EmailConstraint; I suppose we should be consistent.

Trying to make the title make sense :)

LGTM.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased, back to RTBC.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.