🇩🇪Germany @danielspeicher

danielspeicher → created an issue.

Looks great. Could be merged, if pipeline succeeds.

Could be realted to

https://www.drupal.org/project/invoice_ninja/issues/3421977 📌 Check VAT name before syncing Active

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

Fine for me.

I think, we can close this as well: https://www.drupal.org/project/helpdesk_integration/issues/3461710 🐛 Exception when issue is not synched Active

That is a smart solution, I Think.

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

Looks great!

Looks good!

Pipeline is also running successfully now.

I have also tested the patch, which works fine.

I have created a MR with the changes. The build fails, but I do not know why. The branch seems up to date.

danielspeicher → made their first commit to this issue’s fork.

Ok. I will revert the changes.

danielspeicher → created an issue.

@jonasanne Thank you for providing this patch. We use 10.3.2 and make heavy use of E2E testing with Cypress. So we create a user who creates custom entities and after the test we delete everything. This helps a lot and it works great.

As discussed, this is not the right place here, see #3.

Will do this when I am back next weekend

I have added the test for the event to the existing test class, which tests all the events being fired.
For the new action, I have created a new class.

Feel free to enhance by yourself, if I missed something.
All tests are running.

No problem. I focus on the other issues.

We might, can create an event and use an ECA → and/or DANSE → model to dispatch.

danielspeicher → created an issue.

That will do it. Great!

Thanks for paying attention.

Thanks a lot.

danielspeicher → created an issue.

That's great.

@ sazevedo@ua.pt

I have version 10.3.1 and ECA 2.0 and the error is gone. For 10.3.1 (and for 1.1.7) you do not need to apply the patc anymore.

We need to define what to do, if issues do not get synched. This can happen with the queue in place. In Drupal the issue is stored but not in the helpdesk backend. This happens very rarely, but it can.

danielspeicher → created an issue.

Let us postpone until a real requirement occurs.

Works fine now.

jurgenhaas → credited danielspeicher → .

Works perfectly fine.

Looks good. I also checked the post update script. This works as well.

Thank you. This works.

We still get:

Invalid CI config YAML file
https://git.

drupalcode.org//-/raw//includes/includes/include.drupalci.hidden-variables.yml: Invalid configuration format

Now we get:

Invalid CI config YAML file
https://git.drupalcode.org//-/raw//includes/includes/include.drupalci.hidden-variables.yml: Invalid configuration format

We changed it accordingly. Now we get:

ERROR: Job failed: failed to pull image "drupalci/php--apache:production" with specified policies [always]: Error response from daemon: pull access denied for drupalci/php--apache, repository does not exist or may require 'docker login': denied: requested access to the resource is denied (manager.go:250:1s)

PHP version is missing.

It is a hard fail, because the yml file is invalid, so the pipeline does not even start.

include:
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.main.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.variables.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.workflows.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"

danielspeicher → created an issue.

danielspeicher → created an issue.