🇩🇪Germany @danielspeicher

Works fine now.

jurgenhaas → credited danielspeicher → .

Works perfectly fine.

Looks good. I also checked the post update script. This works as well.

Thank you. This works.

We still get:

Invalid CI config YAML file
https://git.

drupalcode.org//-/raw//includes/includes/include.drupalci.hidden-variables.yml: Invalid configuration format

Now we get:

Invalid CI config YAML file
https://git.drupalcode.org//-/raw//includes/includes/include.drupalci.hidden-variables.yml: Invalid configuration format

We changed it accordingly. Now we get:

ERROR: Job failed: failed to pull image "drupalci/php--apache:production" with specified policies [always]: Error response from daemon: pull access denied for drupalci/php--apache, repository does not exist or may require 'docker login': denied: requested access to the resource is denied (manager.go:250:1s)

PHP version is missing.

It is a hard fail, because the yml file is invalid, so the pipeline does not even start.

include:
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.main.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.variables.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"
  - remote: https://git.drupalcode.org/${_GITLAB_TEMPLATES_REPO}/-/raw/${_GITLAB_TEMPLATES_REF}/includes/include.drupalci.workflows.yml
    rules:
      - if: $CI_PIPELINE_SOURCE == "merge_request_event"
        when: never
      - if: $CI_COMMIT_TAG
        when: never
      - if: $CI_COMMIT_BRANCH == "develop" || $CI_COMMIT_BRANCH =~ "/^feature\/.*/"

danielspeicher → created an issue.

danielspeicher → created an issue.

danielspeicher → created an issue.

Yes, I observed the same. Do we already have a bot user? If no, how can I create a proper one?

danielspeicher → created an issue.

Issue communication is done.

Unfortunately, you cannot download attachments via GitLab API, see https://gitlab.com/gitlab-org/gitlab/-/issues/25838. This is a five-year-old issue, and a lot of people are waiting for it.

There are very nasty workarounds done, but I think we do not want to do this. For example, perform a regular login and get the file like we would do via the Web UI.

So for now, it is possible to upload files from Drupal to GitLab and add it in a comment or issue description. This works fine.

I will create another issue for this missing feature.

danielspeicher → created an issue.

danielspeicher → created an issue.

Another thought, as I haven't tested this on a website yet, what happens after the user clicked on the submit button in the modal dialogue? They should stay on the page, the dialogue should just close, but some sort of success message should be displayed if that's possible.

Good point. I will test this with our new Gitlab project.

That code looks good. What we also wanted to add is to collect some context information in such cases and add that to the new issue before saving and syncing upstream.

Yes, I will open another ticket for that. We should keep the tasks as small as possible.

Like the dashboard module, this task provides a link to the toolbar with an helpdesk specific icon. You need to have the permission to open tickets. I did not make this configurable, since other modules also don´t do this.

Looks good!

danielspeicher → created an issue. See original summary → .

To fulfill this requirement, we want to use ECA, so we have to add an event when the users get synchronized. If that is in place, we can create an ECA model, which determines which helpdesk should be used.

Currently, the default helpdesk is used in any cases.

In GitLab we want to use incidents for the creation of issues.

danielspeicher → created an issue.

danielspeicher → created an issue.

Oh, that is really useful. Did not remember, but we talked about it a few months ago.

Ah, I overlooked the substr for the content path.

What do you mean with Web ui?

Thanks for the review

Please take a look. I am not sure, if that "helper" function is appropriate. Feel free to suggest or refactor.

danielspeicher → created an issue.

Cool. Think that will work now perfecly.

I wrote a new test function testNodeTitleForceClear. As for as I understand your example above: The test creates a node with the title my title and the action sets the title to my title.

Whether the clear nor the force_clear works. See the failed test. Please take a look if the test is appropriate. If not, please adapt.

After debugging conditionally, the test is correct.:

In FiledUpdateActionBase the currentValue and the newValue get trimmed anyway. Line 280 and line 286. So line 289 gets executed and the this causes the function to jump out of the loop in line 298, because the arrays have the same size.

The method setting switch case gets never executed.

Thanks for that hint. I will update the test. You are right, we should tackle this in another issue, but it is hard for me to ignore those smells.

That is a lot but straightforward. The code is more type safe. I searched for tests and the specific events are well covered.

A nice feature. Looks fine.

For me, it is ok.

Shall we open another ticket with that alternative approach you mentioned https://www.drupal.org/project/eca/issues/3389309#comment-15347615 📌 ECA Endpoint not found without second path argument RTBC ?

Yes, that sounds reasonable. Code looks fine as well.

danielspeicher → created an issue.

I have added a test for force_clear. Looks good. I also added a return type in SetFieldValue.php

Please review and set issue to fixed if everything is ok.

danielspeicher → made their first commit to this issue’s fork.

Yes, cool

Makes perfect sense.

Another useful feature.

See related issue

Thanks for fixing the code style issue.

Please take a look at BuildTest.php. I replaced the mode append with merge, because append is tested a lot in the other test classes.

I do not know exactly if all the test values make complete sense. Feel free to adapt. At least we can run that particularly piece of code now.

See my comment in https://www.drupal.org/project/eca/issues/3423162 📌 Restructure tests in render module Active . If these tests are ok, we can fix this one here, too.

jurgenhaas → credited danielspeicher → .

danielspeicher → created an issue.

This is a great enhancement.

This looks good.

Looks good.

Question for comprehension: Do we lose events, if we are early in the bootstrap? As we return NULL.

Makes absolutely sense. Looks good.

Now, multiple contacts for a client can be synced as well.

IN always stores a new version of contacts when an invoice gets updated. So we do not store the contact ID on the Drupal side. Now we are up-to-date regarding contacts after updating a client. IN does not provide an API endpoint for contacts anyway, and that update does not cost any additional performance. They are always attached to a specific client.

But let's discuss.

danielspeicher → created an issue.

Thx. That is really cool.

danielspeicher → created an issue.

For comprehension:

If we process the queue and, the helpdesk systems returns errors and never succeeds. Do we run in an endless loop, or do I miss something?

The solution is working as intended.

Great!

jurgenhaas → credited danielspeicher → .

Now the client, countries and currencies are initialized once when needed. Please take a look.

danielspeicher → created an issue.