- Issue created by @jv24
- Status changed to Needs work
4 months ago 8:39pm 12 July 2024 - π¨πSwitzerland saschaeggi Zurich
I'm moving this back to needs work as the changes seem to only be in the dist folder. Also we would need an MR to run all the tests π
- π§πΎBelarus rahunak
I am faced with problem when page has no elements with css class 'meta-sidebar__trigger'.
(error - Cannot read properties of null (reading 'querySelector'))
sidebarTrigger = document.querySelector(".meta-sidebar__trigger") need to wrap conditions to avoid js error.
- π¨πSwitzerland saschaeggi Zurich
This still needs a MR and I think we can simplify the code down just to
sidebarTrigger.nextSibling?.innerHTML = showLabel;
@rahunak
I am faced with problem when page has no elements with css class 'meta-sidebar__trigger'.
In which situation would that be? I can't think of any we provide out of the box π€
If you use the content hook you might want to switch to the sticky action hook instead (?) - First commit to issue fork.
- Merge request !487Issue #3460390: Ensure sidebarTrigger.nextSibling is not null when showing/hiding toolbar β (Merged) created by danielspeicher
- π©πͺGermany danielspeicher Steisslingen
I have created a MR with the changes. The build fails, but I do not know why. The branch seems up to date.
- Status changed to Needs review
3 months ago 6:30am 26 August 2024 - π©πͺGermany danielspeicher Steisslingen
I have also tested the patch, which works fine.
- π©πͺGermany danielspeicher Steisslingen
Pipeline is also running successfully now.
-
saschaeggi β
committed b98d50b7 on 8.x-3.x authored by
danielspeicher β
Issue #3460390: Ensure sidebarTrigger.nextSibling is not null when...
-
saschaeggi β
committed b98d50b7 on 8.x-3.x authored by
danielspeicher β
-
saschaeggi β
committed 51a39fa2 on 4.0.x authored by
danielspeicher β
Issue #3460390: Ensure sidebarTrigger.nextSibling is not null when...
-
saschaeggi β
committed 51a39fa2 on 4.0.x authored by
danielspeicher β
- Status changed to Fixed
3 months ago 7:52am 29 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.