- Issue created by @freelock
- Merge request !11Issue #3462493: Error: Call to undefined method... β (Merged) created by freelock
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 9:56pm 18 July 2024 - πΊπΈUnited States freelock Seattle
Fix for product variation method name. I have not checked that the method name is the same in the other event classes -- this might need more work if the method name varies depending on which event class is used...
- Status changed to RTBC
about 2 months ago 5:08am 19 July 2024 - Status changed to Needs work
about 2 months ago 5:28am 19 July 2024 - πΊπΈUnited States freelock Seattle
Took a look at the other two classes in the chunk of code related to the fix.
Looks like the "FilterVariationsEvent" class does use getVariations() -- the other two classes use getProductVariation().
- Status changed to Needs review
about 2 months ago 5:37am 19 July 2024 - πΊπΈUnited States freelock Seattle
Ok that should at least not break anything else...
- π©πͺGermany danielspeicher Steisslingen
Thanks for paying attention.
- Status changed to RTBC
about 2 months ago 5:44am 19 July 2024 - Status changed to Needs review
about 2 months ago 12:42pm 19 July 2024 - πΊπΈUnited States nicxvan
I actually updated it to add a new token since FilterVariationsEvent has multiple variations and the other two have only one.
Please test again.
- πΊπΈUnited States nicxvan
Important note, there are now two tokens:
commerce_product_variation singular for one variation and the events:
ProductVariationAjaxChangeEvent
ProductVariationEventcommerce_product_variations plural for multiple variations for the event:
FilterVariationsEvent - Status changed to RTBC
about 1 month ago 3:00pm 25 July 2024 - π©πͺGermany jurgenhaas Gottmadingen
That looks good to me, I'm going to merge and back port this to 2.0.x
-
jurgenhaas β
committed cf25316f on 2.1.x authored by
freelock β
Issue #3462493: Error: Call to undefined method Drupal\commerce_product\...
-
jurgenhaas β
committed cf25316f on 2.1.x authored by
freelock β
-
jurgenhaas β
committed cc787c2f on 2.0.x
Issue #3462493: Error: Call to undefined method Drupal\commerce_product\...
-
jurgenhaas β
committed cc787c2f on 2.0.x
- Status changed to Fixed
about 1 month ago 3:07pm 25 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.