🇩🇪Germany @d4t3r

Account created on 23 March 2018, over 6 years ago
#

Recent comments

🇩🇪Germany d4t3r

I gave MR30 a test on a new drupal, again using 'dual' for text output. No real new informations, but maybe this was intended. Don't know. But here is my review:

The javascript fails opening the formatter configuration while running first time, like patch #11
The 'dual' text output still lacks the information "No own rating" if there are votes from others. See #20
The stars show the wrong colors when using average star display. should be (if logged in) average: orange, user: yellow

After this I tried the other star display options, still using 'dual' for text output:
Average, user and smart seem to work, but dual is broken. Smart and dual should be removed. Smart is mixing display information, dual showing two fivestar widgets? both useless.

🇩🇪Germany d4t3r

Dual text output only works correct if there is a user vote recorded. If there is no own vote (but from others), it shows no information about that situation, instead of someting like "No own vote."
But this should not show up if there are no votes at all, no double output needed.

🇩🇪Germany d4t3r

I am closing this. The update to Drupal 10 solved it. Don't know why.
I don't dare to change configuration any more.

🇩🇪Germany d4t3r

Today i gave the star configurations a chance. Smart and dual seem broken while dual configured as text output.

🇩🇪Germany d4t3r

DrupalBubb created an issue.

🇩🇪Germany d4t3r

Update: I removed the patch again. It turns out, that my comment #162 is a seperate issue.
So this is a 'go' for this patch from my side. Sorry for the wrong information. I will edit the comment and open a new issue.

🇩🇪Germany d4t3r

Can also be interesting in other cases, like node title or user name.

🇩🇪Germany d4t3r

I gave the options for text output "smart" and "user" a try. Works on nodes.
Did not test the other situations like comments, views, percentage vote-type, and stars configurations.
Formatter configuration of the voting field does not open at the first try, second try works always. Can't check on alpha5.

🇩🇪Germany d4t3r

#11 works here. I tested the "dual" option and its ok.
Works together with last "Rate content permission is not ported to D8" patch 🐛 Rate content permission is not ported to D8 Needs work .

🇩🇪Germany d4t3r

I still would prefer a buggy dev version. No version means no future.

🇩🇪Germany d4t3r

@abx: You have been right.
Closing this, because the mentioned issue has a patch solving this.

🇩🇪Germany d4t3r

I tried #156 and it solved my issue. Thanks!

🇩🇪Germany d4t3r

There is a security related update for drupal core available, but not for 9.x
Can we please have a release now?
My dev site works with the patch, with the already posted three issues.

🇩🇪Germany d4t3r

Update: Live System is broken again. I can't configure Superfish to run on a tablet proper due to sf-Touchscreen.
Still running on Drupal 9.5.11 and Bartik theme.
Debugging seems complicated for me, because the desktop version is ok.

🇩🇪Germany d4t3r

Create a menu, add the block using superfish, enable "Expand all menu links" and save. Setting is not saved/loaded.

🇩🇪Germany d4t3r

Create a menu, add the block using superfish, enable "Expand all menu links" and save. Setting is not saved/loaded.

🇩🇪Germany d4t3r

I got it working. Maybe the update fixed my issue, don't know.

🇩🇪Germany d4t3r

This only happens if voted. If count-of-votes = 0 there is no double output

🇩🇪Germany d4t3r
<div class="vote-result js-form-wrapper form-wrapper" data-drupal-selector="edit-result" id="edit-result">    <p>2 Stimmen mit einer Bewertung von 3.5
2 Stimmen mit einer Bewertung von 3.5</p>
</div>

Can you precise question 1?

🇩🇪Germany d4t3r

my installation seems broken, because i can't find 8.8.2:

Fileserver:/srv/www/drupal/web/modules/contrib # grep -i -r '8.8.2' votingapi_widgets/*
Fileserver:/srv/www/drupal/web/modules/contrib # grep -i -r '9.2' votingapi_widgets/*
votingapi_widgets/composer.json:        "drupal/core": "^9.2 || ^10",
votingapi_widgets/votingapi_widgets.info.yml:core_version_requirement: ^9.2 || ^10
🇩🇪Germany d4t3r

I tried latest dev and patched it with #42, which worked with 9.5.11 as far as I tested it. Upgrade status module shows 100%. But upgrade fails:

composer update --with-all-dependencies
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/votingapi_widgets dev-1.x requires drupal/core ^8.8.2 || ^9 -> found drupal/core[8.8.2, ..., 8.9.20, 9.0.0, ..., 9.5.11] but it conflicts with your root composer.json require (^10).
    - drupal/votingapi_widgets 1.x-dev is an alias of drupal/votingapi_widgets dev-1.x and thus requires it to be installed too.
    - Root composer.json requires drupal/votingapi_widgets 1.x-dev@dev -> satisfiable by drupal/votingapi_widgets[1.x-dev (alias of dev-1.x)].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

But i can see:

cat ./web/modules/contrib/votingapi_widgets/votingapi_widgets.info.yml
name: Votingapi Widgets
type: module
description: 'Voting API Widgets.'
package: Voting
core_version_requirement: ^9.2 || ^10

dependencies:
  - votingapi:votingapi
  - drupal:field
🇩🇪Germany d4t3r

I retried on my dev system and my settings work as expected. But the live system fails.
Does providing the easing library solve such problems or how can i do a clean restart? Deleting the block did not help.
Something else to try?

🇩🇪Germany d4t3r

I don't know how I opened this twice.

🇩🇪Germany d4t3r

Today I de-installed the Rate module, it did the same.
If you don't remove a permission and deactivate the module, every related role will be warned and then deleted.
Seems to be something general.

Production build 0.69.0 2024