Created on 13 May 2019, over 5 years ago
Updated 9 September 2024, 4 months ago

I'm creating a new task since this one β†’ seemed aimed at drupal 8.

The included patch adds IPv6 support.
It works by handling everything as IPv6 internally.
IPv4 are first converted to IPv6 using 6to4 notation.

✨ Feature request
Status

Needs work

Version

2.1

Component

Code

Created by

πŸ‡«πŸ‡·France fougere

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    @d4t3r: Have you tried the patch? This feature needs people to test the patch and review it.

    #10 is the current patch for 2.0.x
    #6 is the current patch for 7.x-1.x. It needs to be re-rolled because it no longer applies. I don't know what #13 is or how it differs from #6.

    Neither patch has a hook_update_N() that updates the database schema on existing sites. This is required.

    Neither patch has a test for the update hook to ensure that the update does the right thing on existing sites. This is also required.

    You can help by reviewing the patch, re-rolling the D7 patch and ensuring it's consistent with the 2.0.x patch, fixing the update hook, writing the update tests, or even documenting how you are using this feature.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 7 months ago
    32 pass
  • πŸ‡©πŸ‡ͺGermany yannickoo Berlin

    Thanks for your efforts here! I have re-rolled the patch so it works with the latest 2.0.1.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • Status changed to Needs work 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    I created a MR from the patch in #16.

    Although, since #16 doesn't have an interdiff, I don't know whether it's a re-roll of #10 or what?

    Regardless, this is still "Needs work" because, like I said in #15, this NEEDS a HOOK_UPDATE_N() to update the schema on existing sites and NEEDS AN UPDATE TEST to demonstrate the update hook works properly (see tests/src/Functional/Update/Ip2CountryUpdateTest.php for an example of how to write this test).

    I'm going to touch up the MR a bit depending on what GitLab CI says, but I'm not going to be writing the missing hook or the test for the missing hook at this time.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Everything seems to work except for what I mentioned in #19.

Production build 0.71.5 2024