🇫🇷France @fougere

Sorry about that, I will no longer be pursuing application.

The reasons are a lack of time, and disagreement with the last requested changes.
Ex: I find that enforcing that method declaration fit on a single line makes code less readable.
I also could not find this in the Drupal coding standard documentation.

fougere → created an issue.

Make sure you're using version 1.0.3+.
Prior versions were missing a dependency in composer.json for drupal 10.

What is strange, is those dependencies are not used during shipping method administration.
Do you have the error message ?

Thank you for reporting this!
You can upgrade to version 1.0.4.

Note that it was just a warning, and will not prevent you from creating a shipping method.

In addition to the core_version_requirement, added composer dependency on symfony/property-access.
Tests on drupal 10 fail without it.

Since there are similar projects, the project page must describe what the difference with those projects is, to allow people who are interested in the module to better decide which module they should use.

Done.

Since it is possible to install the module on any Drupal 8 and 9 release, it cannot use PHP features that requires at least PHP 7.4 to work without explicitly require PHP 7.4 or any higher version.

Thank you for picking that up!
I've dropped support for drupal 8 in the .info.yml.
I'll bump the major version for the next release.

The documentation comment for properties must contain a description and a @var line.
The documentation comment for methods must describe parameters and return value.

Done.

I can't help but think this adds a lot of boilerplate. Ex:

  /**
   * Get password.
   *
   * @return string|null
   *   Password.
   */
  public function getPassword(): ?string {
    return $this->password;
  }

The comment is redundant.

PHPCS issues fixed.

Sorry about that.

fougere → created an issue.

Hi there !

Thank you for taking the time to test on Drupal 10 !

I've committed the patch on 1.x-dev.

Currently unit tests fails on Drupal 10 because commerce_shipping_label is not yet compatible.
I will make a stable release when fixed.

Hi there!

Sorry about that, release 1.0.2 should fix this.

fougere → made their first commit to this issue’s fork.

MR opened.

fougere → created an issue.