Correct version in deprecation for #3363424

alexandre.baron@symetris.com → made their first commit to this issue’s fork.

_shY → changed the visibility of the branch 3417668-correct-version-in to hidden.

_shY → changed the visibility of the branch 3417668-correct-version-in to active.

I hope, message changes will don't break pipelines =)

Left some comments

@_shY fyi this was tagged novice and the ticket isn't a day old. Novice issue are intended for newer users and based on your post history you seem to have the experience to not work on novice issue please.

Okay, sure. Sorry for that, I just worked on a related issue, and got a notification about the current one.
I'll take into account that, thanks. =)

No worries! Fine to finish this one since you started just more of a FYI for next time.

Does this issue still require attention?

It seems that the problematic code line has already been removed from the target branch, 11.x.

@pooja_sharma, yes this is still active. The fix needs to be applied to the 10.3.x and 10.4.x branches.

ankitv18 → changed the visibility of the branch 3417668-correct-version-in to hidden.

@quietone I have raised the MR's against respective 10.3.x and 10.4.x branches for permissionHandler with mentioned deprecated message.
But spell-checking pipeline throws error of unable to find remote 10.3.x (See: https://git.drupalcode.org/issue/drupal-3417668/-/jobs/2303155#L26)
Do I need to point the MR against 11.x and close the other related MR?

It might be necessary to push updated 10.4.x and 10.3.x MR branches to the MR fork - this issue might have been created before those branches existed.

So what are the next steps? Any way around to fix this?

I have tried to figure out the issue, basically the both MR are created from 11.x branch & target branch is 10.3.x & 10.4.x (2 diff MR), so Iit seems source & target branch both are diff due to which MR failures occurs.

Ideally, For MR 10.3.x branch the MR should should create from source branch 10.3.x then target branch should be 10.3.x

For MR 10.4.x branch the MR should should create from source branch 10.4.x then target branch should be 10.4.x

@pooja_sharma pinged me in slack and asked for me to take a look. Ended up rebasing both branches. Appears to be passing checks.

Thanks @smustgrave, for your prompt responses & explaining root cause of issue.

Changes looks good to me, Pipeline for both branches 10.3.x & 10.4.x executed successfully

So moving it to RTBC

Committed to 10.4.x, thanks! I did not backport it to 10.3.x because functional code and static analysis sometimes acts on the exact string literal of a deprecation message, so it did not seem worth the risk of breaking something just to correct the slight misinformation in a production branch.

For future reference, if all else fails, hiding/closing the merge request and creating a new one is always a perfectly acceptable option, especially for an issue like this where the diff is trivial but the branch history of core's branches is very divergent.

Thanks everyone!

Adding credit for
@pooja_sharma for helping with Slack discussions about the issue and for uncovering the target branch question. In general, see the issue credit policy for what types of contributions normally receive credit.

xjm → closed merge request !9025

xjm → closed merge request !9026

Thanks @smustgrave!

Correcting the branch metadata for the backport, oops.

Automatically closed - issue fixed for 2 weeks with no activity.