- Issue created by @kim.pepper
- Status changed to Needs review
8 months ago 9:15am 31 October 2023 - last update
8 months ago 30,480 pass - Status changed to RTBC
8 months ago 3:59pm 31 October 2023 - 🇺🇸United States smustgrave
@vbouchet thank you for the recent work on the drupal.org issues. If you could start using gitlab vs uploading patches though. Eventually everything will be on gitlab and patches are no longer auto ran, manually had to trigger those tests. Also gitlab tests take around 10 minutes while drupalCi could be an 1-2 hours. Did nothing wrong but patches are slowly being phased out. Let me know if you have any questions!
But reviewing your patch and deprecation seems correct. Message seems good and all tests updated.
LGTM
- 🇫🇷France vbouchet
Thanks for the headsup @smustgrave. Will try to setup my local for easier work with issue fork. 😉
- Status changed to Needs work
8 months ago 12:02am 11 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
- @_shy opened merge request.
- Status changed to Needs review
8 months ago 11:28am 11 November 2023 - Status changed to RTBC
8 months ago 6:21pm 11 November 2023 - last update
6 months ago 25,992 pass, 1,817 fail - Status changed to Fixed
6 months ago 6:30pm 8 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇳🇿New Zealand quietone New Zealand
The trigger_error here is for deprecating in 10.2.0 and should be 10.3.0. I have made a followup to fix that. 🐛 Correct version in deprecation for #3363424 Active