Add option to show only start or end date in the DateTime Range custom formatter

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The workaround in #87 is such a good tip. This is just what I needed.
{{ field_reservation_time__value|date('U') }}
{{ field_reservation_time__end_value|date('U') }}

Awesome work done here +1 Apart from the work around commented last time, we all do actually need/want progress here, I assume?. Can someone of the patch and discussion involved sum up what the bottom line of to-do's is up-to-date so that others can chime in to help? Last useful comment I found was #75 (thanks, agreed) Would love to know more about the back and forth thoughts on this to not blindly add wrong directions.

Reroll of #86 for current 10.1.x (interdiff empty).
I'm re-adding the patch for optional_end_date module as well, for more visibility.

Fixing PHPStan error from #92.

the latest patch seems also 11.x compatible. so Back to Review

Not sure if an empty post update hook will get the needed changes.

Will need upgrade path tests to verify.

Added an upgrade path and a test for the new formatter setting.

Thanks! Upgrade paths are there so removing tag.

Think last thing we will need is a change record, maybe release notes.

Added a change record and a release note.

On Standard install on 11.x
Installed daterange module
Applied patch
Ran post_update and that ran fine.
Add a daterange field to the Article content type
Verified the config options are there.
Set to only show Start date

Created an Article and fill in daterange field
Verified start date is only shown.

Update to only show end date.
Verified end date is only shown.

Updated to show both
Verified both are shown.

Also seems points in #30 have been address

Hiding old patch files for clarity.

Posted some feedback on the MR

Looking good!! just one nit.

Appears all threads have been answered.

Good progress on this! Posted couple more comments on the MR.

Tested feature manually and reviewed implemented code. Changes looks good to me.

Added comment on the MR regarding the update path.

yash.rode → made their first commit to this issue’s fork.

Changed the update path.

Appears additional feedback has been addressed. Don't see any outstanding tags or anything.

Update hook ran fine locally and tests are all green.

ReRTBC

Posted a review on the MR

I have addressed the feedback, except https://git.drupalcode.org/project/drupal/-/merge_requests/4841#note_234897. Does anyone have any alternative way of doing this.

Here I've worked on a small module, which basically introduces a new format which has this option dropdown to choose from start or end date to show on the frontend.

https://www.drupal.org/project/start_end_date_format →

All the threads are addressed.

I don't think this should be added back to the core, if it was removed from Drupal 8 upwards, there must have been a good reason for this. I think its best suited to be added via some contrib module. Here I've worked on a small module that provides a formatter from where you can choose which date value to show Start or End date. https://www.drupal.org/project/start_end_date_format →

@ahmed.raza if you can find that ticket where it was removed and the reason it was removed that would help, but currently this ticket has momentum and several active participants.

Retested same as #102

On Standard install on 11.x
Installed daterange module
Applied patch
Ran post_update and that ran fine.
Add a daterange field to the Article content type
Verified the config options are there.
Set to only show Start date

Created an Article and fill in daterange field
Verified start date is only shown.

Update to only show end date.
Verified end date is only shown.

Updated to show both
Verified both are shown.

Believe all feedback has been addressed as well. Think the 10.2 window may have been missed but think it could be a highlight of 10.3?

This is off-topic, but has there been any thought of adding the start and end date values as separate field choices, similar to how for multivalue fields your choices are field_myvalue and field_myvalue:delta?

I'm triaging RTBC issues → . I read the IS, skimmed the comments from my last visit here (#75), the MR and the change record.

Thank you for the release note snippet. In the future, it could be less detailed because it will be linked to the change record which can have all the details. After looking at the MR I think the images in the change record are outdated because the casing of the new text has changed.

#120 questions whether this should be done because it was removed from Drupal 8. There has been no investigation into that history. However, a product manager has been reviewing this issue so that is a good indication that this is a desired feature.

I see that this is a very large change 12 files + 728 − 69, larger than the recommended change size → . That makes this challenging. Is there any way to reduce the size? I made two comments on the MR and both require work.

There are also other unresolved threads in the MR some of which were not minor changes.

Still, this is in good shape and close!

I see that this is a very large change 12 files + 728 − 69, larger than the recommended change size. That makes this challenging. Is there any way to reduce the size? I made two comments on the MR and both require work.

not sure about what can be done.

There are also other unresolved threads in the MR some of which were not minor changes.

All the threads are addressed, but I cannot close them, please close them who created the MR.

Other than this, I have addressed all the feedbacks.

Believe additional feedback has been addressed.

@quietone there's 📌 Subsystem maintainer permissions on GitLab Needs work where hopefully submaintainers can help core committers by closing threads. But currently no one but the person who opened the MR can close the threads.

The current MR worked perfectly for a field formatter in a view. Thank you!

MR !4841 does not apply cleanly in Drupal 10.2.2

Various use statements are missing in datetime_range.module.
Once these are copy&paste from unpatched file, this patch works great!

Thank you ♥

Ah, this is my third visit here for triage. The recent changes are from my feedback and they have been addressed.

Leaving at RTBC.

Overall this looks very solid - I had one comment on the presave/post update on the MR.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

omkar.podey → made their first commit to this issue’s fork.

Restoring status.

Depending when this lands can probably open a follow up ticket immediately for 11.x. removal right?

Depending when this lands can probably open a follow up ticket immediately for 11.x. removal right?

No - because the post update will have to be removed once database fixtures are updated, and that should happen only once when we're not going to commit any more to-be-removed updates to 10.3 (probably very close to the 10.3 beta deadline).

Thanks for adding the @todo.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Did my best with issue credit here, but it's a long issue with lots of contributors, so apologies if anyone got overlooked.

Should this be included in the 10.3 highlights list?

113 followers over 9 years I would definitely vote yes for highlighting it

This broke PHP 8.1. It does not support DateTimeRangeDisplayOptions::START_DATE->value

Have to revert sorry.

Let's rework this so it's 8.1 compatible, commit to both branches, then we can open a follow-up to use the PHP 8.2 feature.

Converted the enum back to an interface, which should be 8.1 compatible.

Opened 📌 [11.x] php 8.3 follow up for enum in Datetime range formatter Active for the php 8.2 part.

Please make test data providers static methods.

- Made test data providers static methods.
- Some CS for more "readability"
- Added follow-up issue url for @todo comment.

put back on Needs Review and Version 11.x - as the MR is against this version

p.s. for "no reason" there was a Nightwatch failure for tests/Drupal/Nightwatch/Tests/Olivero/oliveroPrimaryTabsTest.js
but it passed ... on a second attempt.

feedback appears addressed

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

it seems there was update that brroke things on CSpell https://www.drupal.org/project/drupal/issues/3420742 📌 Fix words in test string by changing the string Fixed
updated and put back on previous status.

Glad to see this rolling! +1 for all the hard work in here. Also RTBC from me by local testing.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

quietone → closed merge request !4841

Automatically closed - issue fixed for 2 weeks with no activity.

Why doesn't this work at all when applied as a patch to Drupal 10?

Carlos Romero → made their first commit to this issue’s fork.

Carlos Romero → closed merge request !8356

Carlos Romero → closed merge request !8355