🇵🇹Portugal @rutiolma

This has not been fixed in dev branch and nothing has been committed.
The latest patch introduces a dependency on ".once()" but that should be updated due to CR [#3158256]

rutiolma → created an issue.

First patch fixes SA-CORE-2025-001 and the other one fixes 002 and 003

rutiolma → created an issue.

I gave a try to version 1.0.2 and the problem persists.

I confirm that the patch works with version 1.0.1 but it must be updated to work with 1.0.2

Thanks! I'll make a release with this fix

Thanks! I'll make a release with this fix

Thanks! I'll make a release with this fix

Thanks! I'll make a release with this fix

Thanks! I'll make a release with this fix

Thanks! I'll make a release with this fix

Thank you, it will be on the new release

rutiolma → made their first commit to this issue’s fork.

rutiolma → changed the visibility of the branch menu_link_sync-3339163 to active.

rutiolma → changed the visibility of the branch menu_link_sync-3339163 to hidden.

rutiolma → made their first commit to this issue’s fork.

Thanks! I'll make a release with this fix

rutiolma → made their first commit to this issue’s fork.

This issue was based on Kiso theme but this will affect any theme with a preprocess block that tries to do a Block::load().
As mentioned in the issue description, if we don't pass the $block_id to the $configuration argument, then Block::load() will be done on the plugin id.

I'm proposing a simple patch.
Tests missing

I guess something like this would be enough to fix the issue.
Missing tests tho.

rutiolma → created an issue.

rutiolma → created an issue.

I see that this is very similar to 🐛 Canonical metatag on Views pages no longer refers to current, language page Needs work
Maybe this patch is more generic and could work also for that issue

Hey Damien, the patch on issue 🐛 Generate tokens values method does not take into account the entity language Needs work doesn't really address the issue with webforms.

Webforms, and potentially other config entities accessible through a canonical link, should rely on the current language interface to render the [site:name] token.
I didn't test this with other config entities than webforms but I tried to make a generic patch that should work with every config entity.

rutiolma → created an issue.

Closing in favor of ✨ Allow page title to be used as segments instead of menu link title Needs review

It seems that the status was changed by mistake so I'm putting it back to "needs work"

bernardopaulino → credited rutiolma → .

@simohell, I'm not sure if I fully understand your point about captions because they are selectable just using the keyboard.
In fact, if you "Tab" through, you can select every single option/control on a youtube player so with a combination of "Tab"+"Enter" we are sure that the player keyboard navigation is compliant with WCAG2.1.

The youtube player, by itself, is accessible but the problem lies in the interpretation of "User interface component" concept, as I tried to explain in my comment 7. A youtube player, when embedded on a web page, is not a user interface component according to the definition provided at "Key Terms" > https://www.w3.org/WAI/WCAG22/Understanding/character-key-shortcuts.html

Another approach to this issue would involve creating a button to add the "disablekb=1" to youtube embed iframe, to make it optional, but this would need an extra element on the page (a button or so).
Using "disablekb=1" on a youtube embedded video, seems to be the best way to make your webpage fully accessible and it's necessary for users using a screen reader.

I'm marking this as rtbc because the output generated by the patch was approved by the 2 independent accessibility teams we're working with.

I'm reopening this ticket because I just got feedback from 2 independent accessibility teams regarding youtube embed video player.

It all comes down to the interpretation of "User Interface Component" - on my comment 6 I was interpreting it as "the embedded Youtube video and its control buttons" but that is an incorrect interpretation in the context of what this module does, which is embedding a youtube player on a web page.

At the bottom of the WCAG "understanding" page, it is defined as:
"a part of the content that is perceived by users as a single control for a distinct function"

So a "play" button is a user interface component, but an "embedded youtube video" in its entirety isn't.
Which means that it is considered a violation of EN 301 549 / WCAG and needs to be fixed.

In other words, the "M" for "Mute", "F" for "Full screen" or "K" for "Play/Pause" might only work if the keyboard focus is on the control button itself. Nowhere else.
That's why we need "disabekb=1" to make it accessible.

This is a duplicate of 🐛 Improve required validation of multiple value fields Active

+1 for patch 6

+1 for patch #6

The patch on this issue fixes several issues which are being tackled on #2946320 → and #3155174 →
And, as explained at comment #5, the issue reported here doesn't exist if fast404 whitelist is set.

I'm closing this in favor of #2946320 and #3155174

12.2.0-beta1 released

rutiolma → created an issue.

After a second check and according to the WCAG 2.2 - SC 2.1.4: Character Key Shortcuts (Level A) guideline: Letter, punctuation, number, or symbol characters keyboard shortcuts are allowed if at least one of the following is true:

• A mechanism is available to turn the shortcuts off;
• A mechanism is available to remap the shortcuts...;
• Keyboard shortcuts are only active when that component has focus.

That means we have no issue with YouTube videos, since one-key shortcuts are only active when that video has focus.

@sokru, Youtube's video player offers keyboard shortcuts for certain actions (for example m for mute). These keyboard shortcuts can interfere with screenreader shortcuts, for example.
WCAG only allow one-key shortcuts when there is an option to disable those shortcuts.

This is based on WCAG 2.1.4 specification, see https://www.w3.org/TR/WCAG21/#character-key-shortcuts

The solution is to disable keyboard shortcuts by changing YouTube's default disablekb=0 to disablekb=1

rutiolma → made their first commit to this issue’s fork.

+1 for this patch

This patch introduces a new formatter setting "show_empty" which, when checked, will display the "Empty day notation" on every day of the week, instead of hiding the output.

rutiolma → created an issue.

Updated patch, to work with 2.0.x, latest token module version and Drupal 10

Thank you for your work, this will be available in the next release.

Thank you for your work, this will be available in the next release.

Thank you for your work, this will be available in the next release.

rutiolma → made their first commit to this issue’s fork.

rutiolma → created an issue.

rutiolma → created an issue.

Fixing the error reported at #31

rutiolma → created an issue.

rutiolma → created an issue.

Fix at #6 works well. +1

Actually, I was too fast on my previous comment since the LanguageInterface reference was missing.
Here's an updated patch.

I'm also updating the version this patch applies to since 1.x is not supported anymore.

+1 for the approach at #9
The patch works well

+1 for patch 17

The issue, as described, seems to be related with view_unpublished as mentioned in comment 13
I'm closing this one since there's no clear steps to reproduce the issue and a workaround was provided

I realize now that my patch attempt doesn't deal well with this problem, but it still persists

I just found this issue which, in its core, is the same as #2936297
There you can find the steps to reproduce the problem

Thank you for reporting this. This has been fixed with a previous commit

Fixing previous patch errors.

This patch fixes the problem but in my case it introduces a huge overload. I tried a similar approach which seems to be lighter.

Ludo.R → credited rutiolma → .