- Issue created by @rutiolma
- Status changed to Needs review
9 months ago 3:37pm 22 February 2024 - last update
9 months ago 10 pass - π΅πΉPortugal rutiolma
This patch introduces a new formatter setting "show_empty" which, when checked, will display the "Empty day notation" on every day of the week, instead of hiding the output.
-
johnv β
committed cb8fbc4e on 8.x-1.x authored by
rutiolma β
Issue #3423233 by rutiolma: Show formatter when all days have empty time...
-
johnv β
committed cb8fbc4e on 8.x-1.x authored by
rutiolma β
- Status changed to Fixed
9 months ago 4:19pm 29 February 2024 - π³π±Netherlands johnv
Thanks, added.
I did not like the repetitive code, so the patch is reworked.
Please test dev version. - πΊπΈUnited States skyriter
I noticed that this failed the test pipeline. I think it's because
config/schema/office_hours.schema.yml
was not updated to include "show_empty". - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Status changed to Needs review
9 months ago 5:10pm 1 March 2024 - πΊπΈUnited States skyriter
I moved this to Needs Review after making my MR.
- Status changed to Fixed
9 months ago 7:56pm 2 March 2024 - πΊπΈUnited States skyriter
Thank you for your quick response and action, johnh. We use this module in many of our content types and paragraphs at the VA. Would you mind granting me credit for my involvement on this issue?
Automatically closed - issue fixed for 2 weeks with no activity.