Menu block renders when tree is empty as of 8.x-1.8 [regression]

+1 for patch 17

The patch in #17 is working for some cases but not others.

It seems to me that the obvious solution to avoiding repeated rendering was already mentioned by mglaman back in #15:

add static caching for the build() output, so access builds the block, and calling build() reuses the cached output

Is there some reason why re-using a cache of the rendered block would be problematic? I'm very surprised something along those lines wasn't the original change made for this issue.

#17 did not resolve the issue for me nor some other users.

This new patch implements the caching approach described in comment #26 above (and in #15) to deal with the performance concern raised in 🐛 Module causes double rendering of blocks just to check access Fixed , and restoring the blockAccess() method to fix the bugs described in this issue.

Patch #27 works for our use case.

I think we can close 🐛 Empty blocks get displayed Needs review as a duplicate of this issue (#3271218)?

And maybe add contrib credit here, for folks who contributed over there.

FYI the render|striptags|trim check may not work correctly if the block renders using a lazy builder, there was an issue in the Gin theme where I ran into the same problem.

Patch #27 is also working for me.

At the risk of causing confusion...... #27 fixed our issue of "if page.region_name" being "incorrectly" evaluated as true. We haven't used any of the twig workarounds, nor have we added/used the core patch on 🌱 [meta] Themes improperly check renderable arrays when determining visibility Needs work .

Does that track with what folks expect this patch to do? (I'm very pleased haha, I was just rereading the issue summary today, and I wasn't sure if I lost track of what was meant to be addressed in this issue vs. the core issue.)

-------
Put another way...

Page template excerpt -- "sidebar_primary" is a region that contains a menu block:

      {% if page.sidebar_primary %}
      <div id="sidebar-top" class="secondary">
        {{ page.sidebar_primary }}
      </div>
      {% endif %}

Without the patch (#27), the resulting markup is this:

<div id="sidebar-top" class="secondary"></div>

With #27, the div simply isn't there 🎉 And that's certainly what I was hoping for, but...

Does that fit with everyone's intentions/expectations? -- even without the twig filter workarounds?

Confirming #31, I only applied the patch from #27 and did not change any Twig or check any render arrays.

That's 100% the intention of the patch, yes. It solves the problem raised in 🐛 Module causes double rendering of blocks just to check access Fixed without the side-effect of causing the present issue (and in turn causing people to use twig-based workarounds); so what you're seeing is exactly what's intended.

Thanks @jweowu for fixing the regression without too much changes. It seems like people are happy with this change and it will be in the next release

Automatically closed - issue fixed for 2 weeks with no activity.