This module's blocks cause a double render just to check block access. This is causing performance problems.
https://git.drupalcode.org/project/menu_block/-/blob/8.x-1.x/src/Plugin/...
$build = $this->build();
if (empty($build['#items'])) {
return AccessResult::forbidden();
}
Only page_cache could protect from this. Not dynamic_page_page or render cache.
Removing existing check. Just return an empty array.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Or revert and add static caching for the build() output, so access builds the block, and calling build() reuses the cached output.
I believe this is the correct solution. I've implemented it in https://www.drupal.org/project/menu_block/issues/3271218#comment-15268732 🐛 Menu block renders when tree is empty as of 8.x-1.8 [regression] Needs review