- 🇮🇳India nikhil_110
The above patch is applied successfully for Menu Block v8.x-1.x-dev.
Attaching the screenshot for reference.Test Setps
- Setup Drupal with Menu Block v8.x-1.x-dev
- Go to Administration > Administration > Structure > Block layout > Click the "Place block" button in the desired regionand Choose a block from the "Main Menus" category and enable "Display title".
- 🇺🇸United States alison
I think this issue might could be closed as a duplicate of 🐛 Menu block renders when tree is empty as of 8.x-1.8 [regression] Needs review
It's tough, they were both opened at almost the same time, but I don't think we need both 😖
And #3271218 has been added to #3318811: [META] Plan for Menu block 8.x-1.11 release →
@shelane I see that the patch in #3271218 didn't work for you last year -- I wonder if the latest patch on that issue might work for you? ( https://www.drupal.org/project/menu_block/issues/3271218#comment-15268732 🐛 Menu block renders when tree is empty as of 8.x-1.8 [regression] Needs review )
Either way, though, I think the issues should be consolidated -- maybe a maintainer will add contrib credit for folks who've contributed to this issue (not my call, lucky for me 😆).
- 🇳🇿New Zealand jweowu
Agreed. My recent patch in 🐛 Menu block renders when tree is empty as of 8.x-1.8 [regression] Needs review restores the
blockAccess()
method like the patch in this issue, but additionally adds caching to retain the performance improvement which had motivated the removal of that method, so it would be great if people using the patch from here could test my patch in the other issue.