🇸🇪Sweden @peter törnstrand

Released in 1.0.2.

Released in 1.0.2.

Released in 1.0.2.

peter törnstrand → made their first commit to this issue’s fork.

peter törnstrand → made their first commit to this issue’s fork.

Also rename the class from BankidSettingsForm to BankIDSettingsForm.

peter törnstrand → created an issue.

This also improves CSP stuff by getting rid of unsafe inline scripts so it should be a win/win if I can get it working.

Does this mean that I should not develop CSP nonce support for this module? I'm getting rid of insecure-inline on a project I'm working on and the only problem left is this module. I was just about to begin working on a patch when I read the above.

I was going for the same solution as in ✨ Support Content Security Policy Needs review

Released in 1.0.3.

peter törnstrand → created an issue.

Released in version 1.0.4.

peter törnstrand → created an issue.

peter törnstrand → created an issue.

I am not against a configuration form for the module as I stated in my reply:

But, I can see that a config form for this is warranted.

So if you check the DEV release you will see I have added a config form.

This will be released together with fixes for Drupal 11, so if you need it right away use the 1.0.x-dev version.

peter törnstrand → created an issue.

In current implementation menu tree works for the 'page' bundle only. For example. if you create a new one custom bundle for node - it will not work there at all. It's from the box.

This is not true. You can just edit the menu_tree.settings.yml in your config folder and add all the bundles you want using the menu tree widget. Don't forget to import the config after (drush cim).

bundles:
  - page
  - article
  - custom_bundle

But, I can see that a config form for this is warranted.

Commited and included in release 1.0.3.

I can't remember why I made config for this. But the way forward is to create a settings form for this as it will break existing installations just changing the behavior.

Fixes, will be in release 1.0.3

If you can refactor this to not use jQuery I will commit this.

Will be in next release, 1.0.3.

I can't reproduce this on a clean install using Drupal 11.0.1 and Menu tree 1.0.2. Will try Drupal 10 when I get a chance.

Done. Thanks.

Peter Törnstrand → created an issue.

Peter Törnstrand → created an issue.

I'm still having this issue with Drupal 10.2.5 and latest stable release of Gin and Gin toolbar.

Yes, the pattern #([^"])?(https?://[^\s<]+)([^"])# works for all three cases.

Sorry for late reply. I have not tried it beyond my own use case. I will test and report my findings.

Thanks, merged and release 1.0.1 created.

Still having issues with this using beta7, if I change the regexp to #([^"])?(https?://[^\s<]+)([^"])# it works. Made the first match capturing group optional.

Peter Törnstrand → created an issue.

Peter Törnstrand → created an issue.

Thanks, will have a look.