Account created on 14 May 2008, almost 17 years ago
#

Recent comments

🇸🇪Sweden peter törnstrand

Well, I guess it removed it because it is a terrible UI experience. I could perhaps make it a settings to display the weight. But then we would also need to print the weights of the existing items so you know what weight to set.

🇸🇪Sweden peter törnstrand

And also, have a look at the Drush command monitoring:run. It can output results in different formats. See code https://git.drupalcode.org/project/monitoring/-/blob/8.x-1.x/src/Command...

🇸🇪Sweden peter törnstrand

I second that. I can see that there is support for REST exports in the code and I guess that is the way to go? I also found this issue #2398835: Readd icinga integration where the Icinga integration module is removed from the code.

🇸🇪Sweden peter törnstrand

You could have a look at how Google Tag solved this issue in Support Content Security Policy nonce Active . I think you could basically base your whole solution on the patch in that issue. Just copy & paste :-)

🇸🇪Sweden peter törnstrand

drupal supports this out of the box by having the new annotation

@borisson_ I tried Googling for documentation on these new annotations. Did not find anything. Can you point me in the right direction on these new annotations?

🇸🇪Sweden peter törnstrand

I managed to get the upgrade done. Please close this issue.

🇸🇪Sweden peter törnstrand

This was way more complicated that I thought. The trick with hiding repeating date instances with #access = FALSE works just fine for the widget display but not when it comes to deleting values.

With a variant of the patch above I got it working so that if you have a repeating date with four instances you can click the Delete button four times to delete the complete "set".

Not very good.

🇸🇪Sweden peter törnstrand

And here is the patch. This is done against version 4.1.6.

🇸🇪Sweden peter törnstrand

Also rename the class from BankidSettingsForm to BankIDSettingsForm.

🇸🇪Sweden peter törnstrand

This also improves CSP stuff by getting rid of unsafe inline scripts so it should be a win/win if I can get it working.

Does this mean that I should not develop CSP nonce support for this module? I'm getting rid of insecure-inline on a project I'm working on and the only problem left is this module. I was just about to begin working on a patch when I read the above.

I was going for the same solution as in Support Content Security Policy nonce Active

🇸🇪Sweden peter törnstrand

Released in version 1.0.4.

🇸🇪Sweden peter törnstrand

I am not against a configuration form for the module as I stated in my reply:

But, I can see that a config form for this is warranted.

So if you check the DEV release you will see I have added a config form.

This will be released together with fixes for Drupal 11, so if you need it right away use the 1.0.x-dev version.

🇸🇪Sweden peter törnstrand

In current implementation menu tree works for the 'page' bundle only. For example. if you create a new one custom bundle for node - it will not work there at all. It's from the box.

This is not true. You can just edit the menu_tree.settings.yml in your config folder and add all the bundles you want using the menu tree widget. Don't forget to import the config after (drush cim).

bundles:
  - page
  - article
  - custom_bundle

But, I can see that a config form for this is warranted.

🇸🇪Sweden peter törnstrand

I can't remember why I made config for this. But the way forward is to create a settings form for this as it will break existing installations just changing the behavior.

🇸🇪Sweden peter törnstrand

If you can refactor this to not use jQuery I will commit this.

🇸🇪Sweden peter törnstrand

I can't reproduce this on a clean install using Drupal 11.0.1 and Menu tree 1.0.2. Will try Drupal 10 when I get a chance.

🇸🇪Sweden peter törnstrand

I'm still having this issue with Drupal 10.2.5 and latest stable release of Gin and Gin toolbar.

🇸🇪Sweden peter törnstrand

Yes, the pattern #([^"])?(https?://[^\s<]+)([^"])# works for all three cases.

🇸🇪Sweden peter törnstrand

Sorry for late reply. I have not tried it beyond my own use case. I will test and report my findings.

🇸🇪Sweden peter törnstrand

Thanks, merged and release 1.0.1 created.

🇸🇪Sweden peter törnstrand

Still having issues with this using beta7, if I change the regexp to #([^"])?(https?://[^\s<]+)([^"])# it works. Made the first match capturing group optional.

Production build 0.71.5 2024