Automated Drupal 11 compatibility fixes for extra_field

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

Patch including rector's fixes from extra_field.2.x-dev.rector.patch, fixing ExtraFieldManagerBase.php and info.yml file fix.

grevil → changed the visibility of the branch 3455216-automated-drupal-11 to hidden.

I've worked a bit on this issue. Most CS issues are now fixed (except for phpstan).

Also tests are passing, but are marked as failed in gitlab CI because of this error:

1) Class Drupal\extra_field_test\Plugin\ExtraField\Display\AllNodeTypesTest declared in /builds/issue/extra_field-3455216/tests/modules/extra_field_test/src/Plugin/ExtraField/Display/AllNodeTypesTest.php does not extend PHPUnit\Framework\TestCase

That error is correct. It extends "ExtraFieldDisplayBase" therefore shouldn't be suffixed with "Test" same with all the other files in "Display" and "Form".

Tests are passing again.

#MR 18 works for D11. Tested on vanilla D10 site as well. Moving it to RTBC.

MR #18 works with D11. Also tested in vanilla D10.

@pcambra The test changes were discussed in comment #9 📌 Automated Drupal 11 compatibility fixes for extra_field Needs review above.

...I would definitely create a D11 version and keep the D9/10 alone, pretty sure that we will have deprecations.

Based on this comment, it appears like the approach that has been taken in this MR is not what you would like to see.

Could you advise on what you would want to be able to get to an MVP Drupal 11 release?

@thejimbirch there are still quite a few questions on the MR and I would like to keep the D11 compatibility in one commit without unrelated stuff, the main reason I haven't move forward with it is that additional dependency it seems to be adding: https://git.drupalcode.org/project/extra_field/-/merge_requests/18#note_...

        "chi-teck/drupal-code-generator": "3.6 || ^4.1"

I'm going to open a 1.x branch for D11 so we leave D9/10 alone where it is.

Thanks, I appreciate the effort to move this issue forward.

This is the last module I need to be able to move my project template to D11!

So, I focused on things to fix for D11 compatibility (+ unit tests).
Now GitlabCI is enabled, we'll need a followup issue for coding standards cleanup, though.

Plus, according to deprecations in this module's code, some changes also have to be made before releasing a 3.0 version (see \Drupal\extra_field\Plugin\ExtraFieldDisplayManagerInterface::fieldInfo()). I believe that should be another followup task.

duaelfr → changed the visibility of the branch project-update-bot-only to hidden.

@pcambra #19: Changes in test classes may seem unrelated but tests are failing without these because classes ending with "Test" are considered as test classes by PHPUnit so it tries to run them.

I removed some warnings: phpstan, phpcs etc. Also pipeline now run on D11,D10.
Ready to review.

@pawelgorski87 Thank you for your contribution. The maintainer (aka @pcambra) asked to only handle things related to D11 compatibility in this issue, though. That's why those other fixes had been done in 📌 Fix code quality issues reported by GitlabCI Active . Would you mind rollbacking your changes, please?

Sure! Thanks for info

Looks like a new MR has been created with less changes. Hopefully this will get us for a full Drupal 11 release. Marking as RTBC to see if @pcambra can review.

@duaelfr, I think all works fine now on D11, Could we marks as RTBC?

This is great, thanks for all the work and follow ups!

I think this issue is intended to leave open in case there's more stuff coming from the bot?

I think now that Drupal 11 release, the bot is no more. I have closed all of mine.

Well, there's that :) thanks Jim!

Automatically closed - issue fixed for 2 weeks with no activity.