- Issue created by @finnsky
- Status changed to Active
3 months ago 8:21pm 22 June 2024 - ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ made their first commit to this issueโs fork.
- Merge request !8509ID attr on h4 and aria-labelledby attr added on ul โ (Open) created by Unnamed author
- Status changed to Needs review
3 months ago 3:56am 24 June 2024 - ๐ฎ๐ณIndia Gauravvv Delhi, India
The
<li id="navigation-link-navigationcreate">
tag id is used on the buttons asaria-controls="navigation-link-navigationcreate"
. This is important for screenreaders to understand the relationship between the button and the<li>
it controls.I am in favor of not removing the ID attr from
<li>
. - Status changed to Needs work
3 months ago 1:26pm 24 June 2024 - ๐บ๐ธUnited States smustgrave
It's small change but issue is marked major and seems to be a regression (or revert). So think some test coverage would be good, just a simple assertion
- ๐ท๐ธSerbia finnsky
We just removed that from Twig in linked ticket. In current ticket we need to decide if that title needed or not.
And if yes we need to add this with JS because of caching reasons.Also hat titles were added initially from first days of development. And then we created others on block level. So probably they are artefacts and can be ignored.
- ๐ท๐ธSerbia finnsky
finnsky โ changed the visibility of the branch 3452724-add-back-the to hidden.
- ๐บ๐ธUnited States smustgrave
Still would vote to added test coverage though
- ๐ท๐ธSerbia finnsky
marking as bug because it's an a11y regression
We not sure yet.