back the ID and aria-labelled-by with JS

marking as bug because it's an a11y regression

The <li id="navigation-link-navigationcreate"> tag id is used on the buttons as aria-controls="navigation-link-navigationcreate". This is important for screenreaders to understand the relationship between the button and the <li> it controls.

I am in favor of not removing the ID attr from <li>.

It's small change but issue is marked major and seems to be a regression (or revert). So think some test coverage would be good, just a simple assertion

We just removed that from Twig in linked ticket. In current ticket we need to decide if that title needed or not.
And if yes we need to add this with JS because of caching reasons.

Also hat titles were added initially from first days of development. And then we created others on block level. So probably they are artefacts and can be ignored.

finnsky → changed the visibility of the branch 3452724-add-back-the to hidden.

Still would vote to added test coverage though

marking as bug because it's an a11y regression

We not sure yet.

Removing the "prove the need" because it's proven already that this is necessary to fix 📌 Implement a caching strategy for the menu links Active . Discussing this with @plopesc.

I think it still requires some prove label in title ;)
I see now real chaos in titles
https://gyazo.com/0f847b120acbbc46226ddfc0cf47815e
we have h2 and h4. which is real title here? and which one should be aria label?

Adding the "Drupal CMS release target" to see if we could hopefully get to it.

The MR adds these back in the twig template, but the issue summary and linked issue mention it needs to happen via js to prevent caching issues. Also I can't yet find an explanation of what the caching issues are/were anywhere yet. Just looking at the MR I don't see why that would be a problem but could be missing something.