Provide a NavigationLinkBlock Plugin and use Help as an usage example

Postponing due to necessary implementation discussion.

Working on it!

As discussed with @ckrina in Portland, this new block will be hidden by now, but used for the Help Navigation item for testing purposes and simplify the footer logic.

Added functional tests to ensure link access rules are preserved.

Attaching screenshot to ensure that there are no visual regressions.

Love the thought here. One thing I noticed is that the spacing in the footer has some regressions.

Will also go through a static review shortly.

Gauravvvv → made their first commit to this issue’s fork.

This is looking great. RTBC for me.

I think this needs an issue summary update and a change record.

I'll take a crack at writing a change record here.

Updated the issue summary as well as drafted a change record. First time drafting a change record, so let me know if I missed the mark in any way.

I'm also unclear if I could have put it back to RTBC in this instance? Would be curious to learn process there too. Thanks!

Yes fine to put it back to RTBC if you added a change record or similarly fixed issue metadata.

The last question I have is whether the icon class in config is consistent with the current plans for icons?

Icon config is consistent with the current icon approach.

There's no clear direction for final icons yet.

I think that CSS can be simplified. But i don't want to block this feature.

Let's fix CSS here:

https://www.drupal.org/project/drupal/issues/3450103 ✨ .admin-toolbar__footer CSS fix. [follow up] Active

Left some comments/questions on the MR

There's also some existing open threads that I'm not sure have been addressed.

Love this, much cleaner than how we were doing 🙌

Thank you for your comments in the MR.

Worked on them and I think this is ready for another round of reviews.

Adding reference to follow-up created: 📌 Add a generic trait for logic to convert references into Urls in LinkWidget Active

@larowlan After searching through the issue queue, I have seen that 📌 Fix Block config entity type config schema violations: weight, property Postponed already exists and is the key to unlock validation in blocks. There would be no need to create a new issue.

All the MR comments have been addressed, follow up issue for validation referenced, code updated to latest 11.x and conflicts solved.

This is ready for a final round of reviews.

Can confirm that all comments have been addressed. Everything is working well from a functional perspective.

• Installing the module from fresh sets the expected block config for the footer navigation region.
• No visual regressions on the Help link placement or otherwise.