- ๐ท๐ธSerbia finnsky
I added a role and text for the button. Nw tests passed.
But a11y needs to be checked here.
And in general, what is top_bar? What is its role? Header or navigation?
- First commit to issue fork.
- ๐ช๐ธSpain plopesc Valladolid
Since this is not an easy bug to reproduce, created 2 branches:
3508199-navigation-top-bar-axe-test-only
: It contains only the code necessary to make the error visible in Nightwatch tests3508199-navigation-top-bar-axe
: It should contain the code necessary to make the error visible in Nightwatch tests + the changes to fix it
Once tests in
3508199-navigation-top-bar-axe
are green and approved, might be necessary to create a new branch that contains only the code necessary to fix the error. This branch will contain a diff between the 2 original ones, and that's the one that should be merged.I know this is a bit tricky, but I have not been capable to figure out a better flow for this issue. If someone else have a better proposal, please feel free to show your concerns and ideas.
- @plopesc opened merge request.
- @plopesc opened merge request.
- Issue created by @plopesc
- ๐ช๐ธSpain plopesc Valladolid
Created MR 11227 that demonstrates that test-only changes break the Nightwatch test, while the original MR 11124 is still green.
- @plopesc opened merge request.
- ๐ฌ๐งUnited Kingdom catch
I'm not sure the test only job supports nightwatch at all.
It might be worth a second, test only MR, to show the nightwatch test failing without the fix just to make sure it's not a bigger CI issue.
- ๐ช๐ธSpain plopesc Valladolid
Made some new changes in the Nightwatch test to ensure that cache is cleared before reloading the navigation after installing bigpipe and it failed locally without the JS changes.
However, the test-only job stays green. I don't see whether the specific nightwatch test was executed either. Could it be something wrong with the CI job?