Fatal error when accessing Navigation Blocks on a minimal profile installation because of the Shortcut block

have tested branch. attached mov of profile and enabling of Navigation.
works as expected!

Will leave it in RTBC but don’t think shortcut should be a hard dependency. A lot of sites don’t use shortcuts. Think navigation should handle if shortcuts isn’t installed.

Navigation module could add the shortcuts block to its own configuration in a hook_modules_installed() and then remove it again in hook_modules_uninstalled(). I think that can probably be done here.

thanks @catch
A good thought around keeping a 'softer dependency' this way.

Not yet, but the logic could switch over once navigation is stable.

Thank you for your work on this.

The root source of this issue is that in LB managing page, apparently NavigatioShortcutsBlock::blockAccess() method is not being invoked.

That module checks whether shortcuts module is enabled or not before continuing.

Form this point I think we have some alternatives:

1. Try to find why blockAccess() is not being invoked and try to invoke it even for the LB config page
2. Add an extra check in NavigatioShortcutsBlock::build() to ensure that Shortcut module is enabled
3. Continue adding shortcut as a navigation dependency. If so, I would remove all the code checking if Shortcut module is enabled

From my perspective, I would avoid the 3rd option because that would add an unnecessary dependency for the future.

Agree 3 feels like the worst option

Created 🐛 BlockComponentRenderArray::onBuildRender() does not check block access in Preview mode Active

To try to address the LB preview issue.

If that gets in, this one could be closed.

Thanks, i see that aspect too.

🐛 In a Drupal site with low resource use (minimal profile) Navigations 'Create section' is missing key items. Active had just noticed some other similar dependency calls working a bit strangely still.

Add an extra check in NavigatioShortcutsBlock::build() to ensure that Shortcut module is enabled

This is probably a good idea for a quick fix to stop the fatal error. Can then figure out better how optional support from different modules should be added.

A question for me is if a module wants to add itself to the toolbar on install, and not just as a menu link, should it be able to do that? If so, then implementing that in shortcut module would provide an example.

Opened an alternative approach in MR 7944 which simply returns an empty render array when shortcuts module is not enabled. This avoids the fatal error. Eventually when we can move this logic into shortcuts module, it won't be necesssary.

Agree with the test suggestion by @larowlan. See there is already ShortcutsNavigationBlockTest with a very extensive test in there. Wonder if at the very end could just uninstall shortcut and do some simple assertions everything is fine.

Tests added to MR !7944

smustgrave → changed the visibility of the branch 3445184-fatal-error-when to hidden.

After installing Minimal profile, then going to admin/extend to enable Navigation (alone) it is initializing without error. As we did not enable Shortcuts the item is not there (so far as expected!).
-next, enable shortcuts module. notice: no "(star) shortcuts" appears at top of all others.
- clear cache. does not "(star) shortcuts" item to appear.
-next step to try: disable navigation. LEAVE Shortcuts ENABLED!.
- clear caches.
- re-enable navigation. still no "(star) Shortcuts" item.
---
meanwhile: reinitialize env -- install regular standard profile, then enable navigation -- "(star) shortcuts" is working as expected.

Thank you for your review!

I think the scenario described in your manual test is missing the step to create shortcut links.

When there are no shortcut links to show to the user, the shortcuts navigation block is not rendered.

According to https://git.drupalcode.org/project/drupal/-/blob/11.x/core/profiles/stan.... Standard profile creates some shortcut links by default during installation.

It is possible that this is not happening in minimal, where you need to create some shortcut links by yourself to have access to the shortcuts block.

Could you please repeat your tests and confirm this?

Thank you!

Certainly!
It is true, unless I add an item the main branch item doesn't appear.

🐛 Navigation glitch with Shortcuts and Minimal Profile Active have opened for followup.