- Issue created by @finnsky
- Status changed to Postponed
11 months ago 11:59am 27 May 2024 - Status changed to Active
6 months ago 9:54am 22 October 2024 - First commit to issue fork.
- 🇺🇸United States rsnyd
In this note (https://git.drupalcode.org/project/drupal/-/merge_requests/8011#note_316513), if I understand correctly, @finnsky asks for the margin-block-end style to be changed to padding-bottom and added to the .admin-toolbar__footer rule, as opposed to the .admin-toolbar__footer > .toolbar-block:last-of-type where it currently resides.
If this is all true, the spacing would occur after the collapse button (.admin-toolbar__expand-button) rather than between the 'Help' and links as it does now. So should I add the padding to the bottom of the .admin-toolbar__footer or to the link?
Working on this as a novice to become more familiar with contributing. Thank you for any feedback/advise/criticisms.
- Merge request !100683450103: Changing css from margin-block-end to padding-bottom → (Open) created by rsnyd
- 🇺🇸United States rsnyd
I have made the small change as I understood it. Please let me know if it needs any updates.
- 🇷🇸Serbia finnsky
Thank you for you work here.
I found that this problem a bit deeper than it seems from first view. Added few comments. Not sure yet what to do with this - 🇺🇸United States smustgrave
Based on the comment sounds like this still needs investigation?
Should novice tag be removed?
Replace the margin-block-end style with padding-bottom and apply it to the .admin-toolbar__footer rule, instead of the current .admin-toolbar__footer > .toolbar-block:last-of-type. A space will appear, but beneath the button that toggles the child items.