- last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 4:20am 12 July 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 4:47am 12 July 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 6:33am 12 July 2023 - last update
over 1 year ago 29,716 pass, 1 fail - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #35 for 11.x branch, please review it.
Thanks & Regards,
Mrinalini - Status changed to Needs work
over 1 year ago 6:55am 12 July 2023 - 🇳🇱Netherlands spokje
If I search the codebase of
11.x-dev
after applying the patch I still see 2 occurences of->setAccessible(TRUE)
. - Status changed to Needs review
over 1 year ago 9:14am 13 July 2023 - last update
over 1 year ago 29,811 pass - Status changed to RTBC
over 1 year ago 1:49pm 13 July 2023 - 🇺🇸United States smustgrave
Applying patch and searching for setAccessible(TRUE) and got 0 results.
Tests are green so seems like a non breaking change. - last update
over 1 year ago 29,815 pass - 🇺🇸United States xjm
Adding credits for the aforementioned committer Slack discussions since those are easy to miss. (Didn't do full crediting.)
- 🇬🇧United Kingdom catch
The last 9.5.x bugfix came out last week (a month later than we might otherwise have done it, just because we skipped the previous month but still had some commits on the branch).
So although we missed April for this one, it's actually ideal timing to do it now. Removing the date from the issue title both because it's passed, and I think this is fine to commit now we're down to security-only on 9.5 now, doesn't need to be a 10.2 beta target or anything.
- last update
over 1 year ago 29,815 pass -
longwave →
committed 9884cfbd on 10.1.x
Issue #3224941 by andypost, Akram Khan, ravi.shankar, SandeepSingh199,...
-
longwave →
committed 9884cfbd on 10.1.x
-
longwave →
committed 69333763 on 11.x
Issue #3224941 by andypost, Akram Khan, ravi.shankar, SandeepSingh199,...
-
longwave →
committed 69333763 on 11.x
- Status changed to Fixed
over 1 year ago 3:47pm 18 July 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed 69333763c3 to 11.x (10.2.x) and 9884cfbd90 to 10.1.x. Thanks!
- 🇮🇳India ShariRoluthon
Check the PHP 8.1 Release Notes: Before making any changes, review the official PHP 8.1 release notes and documentation to understand the reasons behind the deprecation or removal of setAccessible() and any recommended alternatives.
Find Affected Code: Identify all occurrences of setAccessible() in your codebase. This can be done through simple text searches or using static analysis tools, depending on the size of your project.
Remove Direct Usage: If the functionality provided by setAccessible() is no longer supported or safe to use, you will need to find alternative approaches to achieve the same functionality without using it. Consider alternatives provided by the language or specific libraries.
Use Reflection Correctly: If you were using setAccessible() to access private or protected properties or methods in tests, consider using the Reflection API to access those elements instead. With Reflection, you can change the accessibility of properties and methods for testing purposes without relying on setAccessible(). This approach allows for better control and reduces potential security risks.
Update Third-Party Libraries: If you are using third-party libraries that rely on setAccessible(), check for updates or look for alternative libraries that are compatible with PHP 8.1 and beyond.
Test Thoroughly: After making the necessary changes, thoroughly test your code to ensure that the removal of setAccessible() does not introduce any regressions or issues in your application.
Update Minimum PHP Version: Update your project's minimum required PHP version to PHP 8.1 to prevent accidental usage of deprecated or removed functions in lower versions.
Automatically closed - issue fixed for 2 weeks with no activity.