- 🇮🇳India bunty oberoi
I have created a Patch for the Autocomplete input text can visibly overflow under the magnifier icon. Please Review
- 🇺🇸United States bnjmnm Ann Arbor, MI
If you look at the end of the Custom Commands failed output it provides instructions on running the checks locally so you can be assured it works before uploading a patch to an issue.
Here's an excerpt:To reproduce this output locally: * Apply the change as a patch * Run this command locally: sh ./core/scripts/dev/commit-code-check.sh OR: * From the merge request branch * Run this command locally: sh ./core/scripts/dev/commit-code-check.sh --branch 10.1.x --- Errors --- - Status changed to Needs review
over 1 year ago 3:13am 16 March 2023 - 🇮🇳India gauravvvv Delhi, India
Updated short hand properties in #74, Attached interdiff for same.
- 🇮🇳India bunty oberoi
Hi Gauravvvv,
The patch applied cleanly.
Autocomplete input text is looking fine now Here are the screenshots. - Status changed to Needs work
over 1 year ago 2:03pm 16 March 2023 - 🇺🇸United States smustgrave
Removing credit for bad rerolls
This appears to need an issue summary also.
- 🇺🇸United States smustgrave
IS is incomplete, no steps to reproduce, proposed solution, if UI change screenshots are needed.
- Status changed to Needs review
about 1 year ago 11:19am 16 October 2023 - Status changed to Needs work
about 1 year ago 2:15pm 16 October 2023 - First commit to issue fork.
- Merge request !8623Autocomplete input text can visibly overflow under magnifier icon → (Closed) created by scott_euser
- Status changed to Needs review
5 months ago 5:11am 2 July 2024 - 🇬🇧United Kingdom scott_euser
- Converted to merge request
- Resolved conflicts
- Updated issue summary
- Status changed to Needs work
5 months ago 12:53pm 3 July 2024 - Status changed to Needs review
4 months ago 4:41am 4 July 2024 - 🇬🇧United Kingdom scott_euser
Thanks! My CSS is poor at best (was more helping to move forward) but thankfully simple enough change for me :) Confirmed, changing
<html>dir attribute to rtl and it looks fine still after this change. - 🇬🇧United Kingdom scott_euser
Does this mean we should move the calc's from
:root {
into the
.js { & .form-autocomplete {
? - 🇬🇧United Kingdom scott_euser
I think yes looking at other pcss files in core, so I have gone ahead and done that.
- Status changed to RTBC
4 months ago 1:37pm 9 July 2024 - 🇺🇸United States smustgrave
Removing issue summary tag as that appears to be updated in #94
Applying the MR I'm getting the same results as the after screenshots provided in the summary and see all threads are resolved.
LGTM
- 🇫🇷France nod_ Lille
Committed and pushed 90f8dd194f to 11.x and 351c0873ee to 11.0.x and f9e6633c9a to 10.4.x and 42a97ff4f7 to 10.3.x. Thanks!
- Status changed to Fixed
4 months ago 9:33pm 19 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.